Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated terminal occasionally wraps some lines #13554

Closed
atian25 opened this issue Oct 12, 2016 · 8 comments
Closed

Integrated terminal occasionally wraps some lines #13554

atian25 opened this issue Oct 12, 2016 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@atian25
Copy link

atian25 commented Oct 12, 2016

  • VSCode Version: 1.6
  • OS Version: osx

Steps to Reproduce:

  1. start a terminal
  2. type 123456789abcd-
  3. type c
  4. then the c show at next line
  5. type d
  6. cd resume

vscode-termial-typing-bug

@Tyriar
Copy link
Member

Tyriar commented Oct 12, 2016

@atian25 can you use dev tools (Help > Toggle Developer Tools) and inspect the terminal? I'm interested in:

  • How wide the terminal panel is
  • How wide the problem terminal row is and its contents
  • How wide .xterm-rows is

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster terminal Integrated terminal issues labels Oct 12, 2016
@atian25
Copy link
Author

atian25 commented Oct 13, 2016

image

image

image

image

image

image

image

image

@Tyriar
Copy link
Member

Tyriar commented Oct 13, 2016

@atian25 do you have a custom font in settings? Can you try changing it to a different one and see if it still reproduces?

Related: xtermjs/xterm.js#227

@atian25
Copy link
Author

atian25 commented Oct 13, 2016

not, editor.fontFamily is default as "editor.fontFamily": "Menlo, Monaco, 'Courier New', monospace"

and after some try, it' must be Menlo problem, remove it and everything is ok

@atian25
Copy link
Author

atian25 commented Oct 13, 2016

so @Tyriar the only way is to remove this font ?

@Tyriar
Copy link
Member

Tyriar commented Oct 13, 2016

@atian25 well that may be a temporary fix if it's super annoying. This looks like an upstream issue to do with width not being uniform on some fonts.

@Tyriar
Copy link
Member

Tyriar commented Oct 26, 2016

Thing I managed to repro this (or something very similar) using my normal font Hack on Ubuntu:

image

Adding styles .xterm-rows { right: 0; } OR .xterm-rows > div { white-space: nowrap; } fix it. It's strange how inconsistent this wrapping is though considering that the lines should fit inside the container.

@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed info-needed Issue requires more information from poster labels Oct 26, 2016
@Tyriar Tyriar modified the milestones: November 2016, October 2016 Oct 26, 2016
@Tyriar Tyriar closed this as completed in 4a83b37 Oct 27, 2016
@Tyriar Tyriar removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Oct 27, 2016
@Tyriar
Copy link
Member

Tyriar commented Oct 27, 2016

Put out a PR upstream and pulled the change into vscode since we forked the css file.

@octref octref added the verified Verification succeeded label Oct 27, 2016
@Tyriar Tyriar changed the title vscode 1.6 terminal typing problem Integrated terminal occasionally wraps some lines Oct 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants