Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console should not say 'no suggestions' if the debug adapter doesn't support completions #13893

Closed
roblourens opened this issue Oct 17, 2016 · 1 comment
Closed

Console should not say 'no suggestions' if the debug adapter doesn't support completions #13893

roblourens opened this issue Oct 17, 2016 · 1 comment
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@roblourens
Copy link
Member

If supportsCompletionsRequest is not returned from initializeRequest, it might look better if the 'no completions' popup is not shown when the user presses ctrl+space. It looks like the debug adapter is trying to show completions and failing.
@isidorn
Copy link
Contributor

isidorn commented Oct 24, 2016

This is what we do in the editor when no completions are available.
I do not want to treat the repl editor as a special editor and display it differntly

Thus closing as will not fix / as designed

@isidorn isidorn closed this as completed Oct 24, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roblourens @weinand @isidorn