Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the find widget via x does not clear find in selection toggle #15959

Closed
ericksonivanowski opened this issue Nov 23, 2016 · 0 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations verified Verification succeeded
Milestone

Comments

@ericksonivanowski
Copy link

  • VSCode Version: 1.7.2
  • OS Version: Windows 10

The selection area of find/replace keeps popping up even after I close the dialog find/replace by pressing the 'close' button.

PS: When the document is not saved, the expected behavior occurs.
When I press ESC the expected behavior also occurs. Only when the document is saved does this bug occur.

Steps to Reproduce:

  1. Open New Document

  2. Paste:
    Test Select
    Test Select
    Test Select
    Test Select

  3. Save document

  4. Press Ctrl + A

  5. Press Ctrl + F

  6. In Dialog Find/Replace press button 'Find in Selection'

  7. Press button 'Close' in right of 'Find in Selection'

Steps to reproduce expected:

  1. Press Ctrl + A
  2. Press Ctrl + F
  3. In Dialog Find/Replace press button 'Find in Selection'
  4. Press ESC
@alexdima alexdima changed the title Continues showing selection area after find/replace 'in selection' Closing the find widget via x does not clear find in selection toggle Nov 30, 2016
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations labels Nov 30, 2016
@alexdima alexdima added this to the Backlog milestone Nov 30, 2016
@rebornix rebornix self-assigned this Apr 28, 2017
rebornix added a commit to rebornix/vscode that referenced this issue Apr 28, 2017
@rebornix rebornix modified the milestones: Backlog, May 2017 May 6, 2017
@roblourens roblourens added the verified Verification succeeded label May 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants