Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First https request is responsible for 18% of windows startup time #16065

Closed
jrieken opened this issue Nov 25, 2016 · 5 comments
Closed

First https request is responsible for 18% of windows startup time #16065

jrieken opened this issue Nov 25, 2016 · 5 comments
Assignees
@joaomoreno @jrieken @aeschli
Labels
perf windows VS Code on Windows issues
Milestone
November 2016

Comments

@jrieken
Copy link
Member

jrieken commented Nov 25, 2016

  • windows 10, latest insiders
  • open a folder, close all editors, don't show viewlets
  • start profiling
  • reload
  • 馃悓 there is call to the getmac node module that takes ~1 second. That call is made always when the extension gallery services comes up. That call is also made on first startup when telemetry data is initialised.

We should consider replacing this module with os#networkinterfaces

screen shot 2016-11-25 at 16 14 59
@jrieken jrieken added perf windows VS Code on Windows issues labels Nov 25, 2016
@jrieken
Copy link
Member Author

jrieken commented Nov 25, 2016

Note that this only reproduces on insiders or when configuring dev with an extension gallery. Windows only as it seems.

@jrieken jrieken changed the title getmac is slow on windows getmac is responsible for 18% of windows startup time Nov 25, 2016
@jrieken
Copy link
Member Author

jrieken commented Nov 25, 2016

related to #15455

@jrieken
Copy link
Member Author

jrieken commented Nov 25, 2016

getmac vs networkInterfaces on windows 10, times in nanoseconds. unsure why in VS Code it's a second but the relative difference is huuuuge

screen shot 2016-11-25 at 16 37 23

@jrieken jrieken changed the title getmac is responsible for 18% of windows startup time First https request is responsible for 18% of windows startup time Nov 28, 2016
@jrieken
Copy link
Member Author

jrieken commented Nov 28, 2016

This is actually not getmac but creating a secure context a little after that call. We should probably still get rid of that module, but we should also make fix the request service...

@jrieken
Copy link
Member Author

jrieken commented Nov 28, 2016

screen shot 2016-11-28 at 15 52 17

@jrieken jrieken assigned aeschli and jrieken and unassigned ramya-rao-a Nov 28, 2016
This was referenced Nov 28, 2016
Closed
Merged
@jrieken jrieken added this to the November 2016 milestone Nov 30, 2016
@jrieken jrieken closed this as completed Nov 30, 2016
@joaomoreno joaomoreno mentioned this issue Nov 30, 2016
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@jrieken jrieken

@aeschli aeschli

Labels
perf windows VS Code on Windows issues
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
4 participants
@joaomoreno @jrieken @aeschli @ramya-rao-a