Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATA puts types in $HOME/Microsoft #16318

Closed
Instagit opened this issue Dec 1, 2016 · 8 comments · Fixed by #17347
Closed

ATA puts types in $HOME/Microsoft #16318

Instagit opened this issue Dec 1, 2016 · 8 comments · Fixed by #17347
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority linux Issues with VS Code on Linux upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@Instagit
Copy link

Instagit commented Dec 1, 2016

  • VSCode Version: 1.7.2
  • OS Version: Ubuntu 16.04

I have yet to find out how to reproduce this, but VS Code creates a Microsoft/TypeScript/node_modules/ directory with the types-registry npm module in it in the home directory.

The package readme says

This is the source code for the types-publisher service, which publishes the contents of DefinitelyTyped to npm.

I never set anything to be shared or published. So what exactly is this and what does it do?

@chrmarti chrmarti added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Dec 1, 2016
@Instagit
Copy link
Author

Instagit commented Dec 2, 2016

Steps to reproduce:

  1. open VS Code
  2. open any JavaScript file

It only happens for the first JS file that is opened. Could be a bug, too.

@chrmarti
Copy link
Contributor

chrmarti commented Dec 2, 2016

I guess this is from the automatic typings acquisition in recent versions of TypeScript. @Instagit Are you saying the folder is under ~/Microsoft?

@vladima
Copy link

vladima commented Dec 2, 2016

@chrmarti is correct - this is location of global cache for acquired type declarations. These files are downloaded on user machine to power JavaScript intelligence and never uploaded anywhere.

@chrmarti
Copy link
Contributor

chrmarti commented Dec 2, 2016

@vladima What are the paths that are used for this cache on the different platforms? I think on Linux it might make sense to used a folder name with a leading '.' to hide it from default ls and file explorer behavior - like other tools do. /cc @Tyriar

@chrmarti chrmarti assigned chrmarti and unassigned kieferrm Dec 2, 2016
@Tyriar
Copy link
Member

Tyriar commented Dec 2, 2016

Now that you mention this I have this too. We should absolutely not be putting the types in ~/Microsoft. $XDG_CACHE_HOME/typescript would probably make the most sense, where $XDG_CACHE_HOME defaulting to $HOME/.cache if it is not defined as per the XDG Base Directory Specification. I'm proposing typescript/ instead of microsoft/ to prevent potential future conflicts.

@vladima this is actually quite bad imo, is this a purely upstream problem?

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority linux Issues with VS Code on Linux and removed *question Issue represents a question, should be posted to StackOverflow (VS Code) labels Dec 2, 2016
@Tyriar Tyriar assigned Tyriar, kieferrm and mjbvz and unassigned chrmarti Dec 2, 2016
@Tyriar Tyriar changed the title Microsoft/Typescript directory in home directory ATA puts types in $HOME/Microsoft Dec 2, 2016
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 5, 2016
@mjbvz
Copy link
Contributor

mjbvz commented Dec 5, 2016

This issue was moved to microsoft/TypeScript#12674

@mjbvz mjbvz closed this as completed Dec 5, 2016
@Tyriar
Copy link
Member

Tyriar commented Dec 5, 2016

Let's keep this open on vscode to track it. I'd like to mention the fix in release notes when it comes.

@Tyriar Tyriar reopened this Dec 5, 2016
@Tyriar Tyriar added this to the January 2017 milestone Dec 5, 2016
@mjbvz
Copy link
Contributor

mjbvz commented Dec 7, 2016

This is going into TypeScript 2.2, so we will not be picking it up in VSCode 1.8. You can install a TS 2.2 insiders build to your workspace to work around this for now.

@Tyriar Tyriar added the verified Verification succeeded label Jan 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority linux Issues with VS Code on Linux upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants