Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support native tabs on macOS #17199

Closed
aronasorman opened this issue Dec 14, 2016 · 3 comments
Closed

Support native tabs on macOS #17199

aronasorman opened this issue Dec 14, 2016 · 3 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@aronasorman
Copy link

  • VSCode Version: 1.8.0
  • OS Version: macOS 10.12.1

Steps to Reproduce:

  1. Maximize the current VSCode window (fullscreen)
  2. Press Cmd+Shift+N

1.7's behaviour is to spawn the window in a new "application tab" (aka as described in Apple's "merge windows" feature here)

New behaviour: It just spawns a totally separate window, on another desktop.

The old behaviour was really useful in being able to juggle a lot of projects at once. It would be really awesome if it went back to that! I tried reverting window.titleBarStyle to native and then restarting, but no dice.
@potterdai
Copy link

Same problem here. Really need this function back.

@bpasero
Copy link
Member

bpasero commented Dec 15, 2016

This change came through upstream and is tracked at electron/electron#6124

@bpasero bpasero added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Dec 15, 2016
@bpasero bpasero changed the title VSCode no longer merging all windows on MacOS Support native tabs on macOS Dec 15, 2016
@bpasero bpasero removed their assignment Dec 15, 2016
@bpasero bpasero mentioned this issue Dec 18, 2016
Closed
@bpasero
Copy link
Member

bpasero commented Jan 17, 2017

#15478

@bpasero bpasero closed this as completed Jan 17, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aronasorman @bpasero @potterdai