Terminals launching using terminal.integrated.cwd do not check for invalid paths

[Tyriar]

Invalid paths will cause the terminal to start at terminalProcess.js' dir.

[millergarym]

Is a variable a valid option to terminal.integrated.cwd?
If so what variables?
eg the directory of the current active document.

This would replace the need for @Tyriar's addin.
https://marketplace.visualstudio.com/items?itemName=Tyriar.vscode-terminal-here

#17387 (comment)
#15531 (comment)

[Tyriar]

@millergarym created #31677

[lifez]

@Tyriar Would you suggest me to work on this thing and #31677

[Tyriar]

Sorry for the delay, anything with the help wanted label is up for grabs 😃

[sylann]

I'm sorry if it's not the correct issue to post this. I came here from following a bunch of now closed issues.
So in case it could help you figure out what's wrong with this:
I am having the very same error as described by @siegebell here.
It started just after I upgraded budgie 17.10 (based on ubuntu) to 18.04

It happens only if all 3 of these conditions are met:

1. I have no terminal opened in the current instance of vscode.
2. I have several folders opened in the workspace
3. I have no terminal.integrated.cwd specified (more on this below).

More details:

If I use the command workbench.action.terminal.new instead of the command workbench.action.terminal.toggleTerminal,
it prompts me to chose one of the opened folders in the workspace, and the terminal always starts successfully in this case.

When trying to toggle the terminal (without any currently opened):
The terminal fails to start with: terminal.integrated.cwd set to either ~ or $HOME.
But the terminal starts successfully with a static value such as /home/myusername.

[Amanej]

I have the same issue as #56849 , is there any solution to do this ?

Split Terminal used to work, but now just trows
'chdir(2) failed'
and
'The terminal process command '/bin/bash -l' failed to launch (exit code: 1)'

[timdmackey]

I noticed this problem for the first time today. I get the same chdir(2) failed error when I try to split the terminal.

• The issue occurs whenever I use the "Split Terminal" command.
• Using the "New Terminal" command does not throw this error.

[timdmackey]

After investigating a little further, the problem in my case is being caused by a unicode character in my file path. One of the folders in my file path is Tim’s Documents, and the apostrophe (right single quote) is the root of the problem. Removing that character from the folder name fixes it.

I'm not sure why this only shows up with the "Split Terminal" command, though.

[Tyriar]

@timdmackey the cwd in split terminal is driven by this:

It sounds like inherited (likely) breaks when it contains a '? Can you create a new issue for this?