Explorer: Does not sort files and folders with numerical values accordingly #17495

Closed
AStodgyGuy opened this Issue Dec 18, 2016 · 5 comments

Projects

None yet

6 participants

@AStodgyGuy
  • VSCode Version: Code 1.8.0 (3874693, 2016-12-13T17:45:32.595Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
python donjayamanne 0.5.5
java-debug DSnake 0.0.2
cpptools ms-vscode 0.9.3
csharp ms-vscode 1.5.3
java redhat 0.0.7

Steps to Reproduce:

  1. Create 3 folders called "Folder 1" , "Folder 2" and "Folder 10"
  2. Folder 10 appears in between Folder 1 and Folder 2.

image

@kieferrm
Contributor

The macOS Finder, for example, handles this case correctly.

@bpasero bpasero was assigned by kieferrm Dec 19, 2016
@bpasero bpasero assigned joaomoreno and unassigned bpasero Dec 19, 2016
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Jan 3, 2017
@bpasero
Member
bpasero commented Jan 3, 2017

@joaomoreno do you recall any reason why we are not using the comparers.compareFileNames for folders in https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/browser/views/explorerViewer.ts#L654 ?

@bpasero bpasero added this to the January 2017 milestone Jan 3, 2017
@bpasero bpasero changed the title from Numerical Folder Issue to Explorer: Numerical folder sorting issue Jan 3, 2017
@bpasero bpasero changed the title from Explorer: Numerical folder sorting issue to Explorer: Does not sort files and folders with numerical values accordingly Jan 4, 2017
@bpasero
Member
bpasero commented Jan 4, 2017

This actually happens for files and folders. A good area for a PR 👍

@bpasero bpasero modified the milestone: Backlog, January 2017 Jan 4, 2017
@bpasero bpasero closed this in #18539 Jan 16, 2017
@bpasero bpasero removed the help wanted label Jan 16, 2017
@bpasero bpasero modified the milestone: February 2017, Backlog Jan 16, 2017
@gulshan
gulshan commented Jan 17, 2017

@bpasero As related, can #5222 also be included in February Milestone?

@bpasero
Member
bpasero commented Jan 17, 2017

Unlikely.

@bpasero bpasero modified the milestone: February 2017, January 2017 Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment