Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer: Does not sort files and folders with numerical values accordingly #17495

Closed
AStodgyGuy opened this issue Dec 18, 2016 · 5 comments · Fixed by #18539
Closed

Explorer: Does not sort files and folders with numerical values accordingly #17495

AStodgyGuy opened this issue Dec 18, 2016 · 5 comments · Fixed by #18539
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone
January 2017

Comments

@AStodgyGuy
Copy link

  • VSCode Version: Code 1.8.0 (3874693, 2016-12-13T17:45:32.595Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
python donjayamanne 0.5.5
java-debug DSnake 0.0.2
cpptools ms-vscode 0.9.3
csharp ms-vscode 1.5.3
java redhat 0.0.7

Steps to Reproduce:

  1. Create 3 folders called "Folder 1" , "Folder 2" and "Folder 10"
  2. Folder 10 appears in between Folder 1 and Folder 2.

image
@kieferrm
Copy link
Member

The macOS Finder, for example, handles this case correctly.

@kieferrm kieferrm added the feature-request Request for new features or functionality label Dec 19, 2016
@bpasero bpasero assigned joaomoreno and unassigned bpasero Dec 19, 2016
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Jan 3, 2017
@bpasero
Copy link
Member

bpasero commented Jan 3, 2017

@joaomoreno do you recall any reason why we are not using the comparers.compareFileNames for folders in https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/browser/views/explorerViewer.ts#L654 ?

@bpasero bpasero added this to the January 2017 milestone Jan 3, 2017
@bpasero bpasero changed the title Numerical Folder Issue Explorer: Numerical folder sorting issue Jan 3, 2017
@bpasero bpasero added file-explorer Explorer widget issues and removed feature-request Request for new features or functionality labels Jan 3, 2017
@bpasero bpasero changed the title Explorer: Numerical folder sorting issue Explorer: Does not sort files and folders with numerical values accordingly Jan 4, 2017
@bpasero
Copy link
Member

bpasero commented Jan 4, 2017

This actually happens for files and folders. A good area for a PR 👍

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities labels Jan 4, 2017
@bpasero bpasero modified the milestones: Backlog, January 2017 Jan 4, 2017
@jchadwick jchadwick mentioned this issue Jan 14, 2017
Merged
jchadwick added a commit to jchadwick/vscode that referenced this issue Jan 15, 2017
@jchadwick
Fixing sorting of directory and filenames with numbers (fixes microso…
2bb0cf9 
…ft#17495)
bpasero added a commit that referenced this issue Jan 16, 2017
@bpasero
Merge pull request #18539 from jchadwick/jchadwick/explorer-sorting-i…
7a949d8 
…ssue

Fixing sorting of directory and filenames with numbers (fixes #17495)
@bpasero bpasero removed the help wanted Issues identified as good community contribution opportunities label Jan 16, 2017
@bpasero bpasero modified the milestones: February 2017, Backlog Jan 16, 2017
@gulshan
Copy link

gulshan commented Jan 17, 2017

@bpasero As related, can #5222 also be included in February Milestone?

@bpasero
Copy link
Member

bpasero commented Jan 17, 2017

Unlikely.

@bpasero bpasero removed this from the February 2017 milestone Jan 17, 2017
@bpasero bpasero modified the milestones: January 2017, February 2017 Jan 17, 2017
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Jan 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
January 2017
Development

Successfully merging a pull request may close this issue.

Fixing sorting of directory and filenames with numbers jchadwick/vscode
6 participants
@joaomoreno @gulshan @bpasero @kieferrm @ramya-rao-a @AStodgyGuy