[scss] scss map syntax showing as an error #1758

Closed
gregornoriskin opened this Issue Jan 3, 2016 · 14 comments

Projects

None yet
@gregornoriskin

If I add a map to a scss file, e.g. "$map: (key1: value1, key2: value2, key3: value3);" it shows as an error. Red squiggly appears under the ":" after the first key and hover message reads ") expected". Despite the error in editor node-sass evaluates map-get correctly over it.

@joaomoreno joaomoreno added this to the Backlog milestone Jan 5, 2016
@aeschli aeschli was assigned by joaomoreno Jan 5, 2016
@aeschli
Contributor
aeschli commented Jan 5, 2016

We don't support the map syntax yet

@aeschli aeschli changed the title from scss map syntax showing as an error to [scss] scss map syntax showing as an error Jan 6, 2016
@basvandenheuvel

Any roadmap on when this will be solved?

@egamma
Member
egamma commented Jan 30, 2016 edited

It is not on top of our backlog currently, sorry.

As a workaround you can disable the built-in validation using

    "sass.validate": false

EDIT corrected to false thanks @rob3c for catching it.

and install extension like stylelint.

@rob3c
rob3c commented Jun 2, 2016

Thanks for the pointer to stylelint. I'm guessing that should be "sass.validate": false instead of true to disable the built-in validation to allow stylelint to work without conflict?

@basvandenheuvel

Any info on this topic :)?

@senseiweb

bumping this, check to see the current pulse - thanks.

@obber obber referenced this issue in Jadaka/open-doors Oct 30, 2016
Merged

๐Ÿ’„ Adds some hip styling groundwork #25

@VishalGulati

any update on this one? I made the setting in settings.json i.e. "sass.validate": false as suggested but still got the same error.

@VishalGulati

update: "scss.validate": false worked!!

@jwatkin
jwatkin commented Nov 16, 2016

Is there a way to vote this up? The basic template provided in a Foundation 6 project contains maps assigned to variables in the default _settings.scss file. I'm new to Sass and Visual Studio Code but so far this seems like a common use case. Thank you.

@mrmlnc mrmlnc referenced this issue in mrmlnc/vscode-scss Nov 16, 2016
Closed

Map type ) expected #25

@gizm0bill

there's also a validation error when trying to declare a rule with a variable in its name
For example: .#{$color-type} { ... warns: [scss] at-rule or selector expected

@Aarilight
Aarilight commented Dec 26, 2016 edited

@aeschli @egamma Do you accept pull requests for this? And if so what do I need to do? I have the multi-arg @each working, trying to get the map assignment done atm but that's harder cause it seems to parse w/ cssParser, and it'd probably be silly to have map parsing in that

EDIT: I now more or less know how this is set up, and have real implementations for maps and multi-arg @each. I also wrote a few parsing tests, but haven't added/implemented any scope changes (it probably won't need them?) One issue I stumbled upon was that vscode is highlighting the entire map thinking it's one value tho--not sure where to look to fix that one. Anyway, my code is in my fork if you want to check them out/use them to jumpstart an official implementation

@egamma
Member
egamma commented Dec 29, 2016

@Aarilight

Do you accept pull requests for this?

In general yes, but I defer to @aeschli whether he has specific concerns. @Aarilight pls keep in mind that we are slower to respond over the holidays and most of the team is on vacation.

@aeschli aeschli modified the milestone: January 2017, Backlog Jan 20, 2017
@aeschli aeschli added a commit to Microsoft/vscode-css-languageservice that closed this issue Jan 20, 2017
@aeschli aeschli [scss] scss map syntax showing as an error. Fixes Microsoft/vscode#1758 a1f31ee
@Aarilight

@aeschli that doesn't add map support to @each, does it? @each can get a comma-separated list of variables from either map entries (two vars, one for prop and one for val), or lists within lists (in which case you can get a var for each sub-list item). Without @each support maps are still kinda annoying to work with in vscode. My fork adds in support for multi-var @each, for reference.

@aeschli aeschli added a commit to Microsoft/vscode-css-languageservice that referenced this issue Jan 23, 2017
@aeschli aeschli support multiple variables in @each (for Microsoft/vscode#1758) 505085c
@aeschli
Contributor
aeschli commented Jan 23, 2017

Thanks for pointing that out. I added support for multiple variables.

@aeschli aeschli added a commit to Microsoft/vscode-css-languageservice that referenced this issue Jan 23, 2017
@aeschli aeschli Multiple variables in @each: support in scope (for Microsoft/vscode#1758
)
3fe805a
@aeschli aeschli referenced this issue Jan 23, 2017
Closed

Test SCSS maps #19068

2 of 2 tasks complete
@isidorn isidorn added the on-testplan label Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment