Search results nav F4 conflicts with the C++ extension #18679

Closed
roblourens opened this Issue Jan 17, 2017 · 5 comments

Projects

None yet

3 participants

@roblourens
Member

@egamma What problem did you say you had with shift+f4? It works as expected for me.

@roblourens roblourens self-assigned this Jan 17, 2017
@egamma
Member
egamma commented Jan 17, 2017 edited

@roblourens my problem was that 'F4' gives focus to the editor and I could not press it repeatedly. I've tried to reproduce it with all extensions disabled and it worked well. Sorry about the false issue.

@egamma egamma closed this Jan 17, 2017
@egamma
Member
egamma commented Jan 17, 2017 edited

@roblourens the culprit is the C++ extension and the SwitchHeaders command (see below).
This means the users of the C++ extensions will have the same issue.

image

@egamma egamma reopened this Jan 17, 2017
@egamma
Member
egamma commented Jan 17, 2017

Given that the C++ extension is popular we should "fix this" by announcing this as a "breaking" key binding change in the release notes.

@roblourens roblourens added this to the January 2017 milestone Jan 17, 2017
@egamma egamma changed the title from Search results nav - shift+f4 to Search results nav F4 conflicts with the C++ extension Jan 18, 2017
@BillDenton

Shouldn't this be moved to C++ extension and the extension change its key mapping?

@roblourens roblourens referenced this issue in Microsoft/vscode-cpptools Jan 23, 2017
Open

New F4 keybinding conflict with vscode #458

@roblourens
Member

Filed an issue on vscode-cpptools, and added to the release notes

@roblourens roblourens closed this Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment