-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard crash (of everything) when debugging nodejs #18758
Comments
for my colleague - this just started. He asked me to try to see if I had the same issues. He rolled back to the previous version of vscode and had the same result. I haven't debugged any node code in a while -- so I'm not sure when it started on my machine.
|
could uninstalling / reinstalling potentially help? any instructions for "cleaning code" from a machine? I hope to get this working soon - I use code all day every day! |
Cannot reproduce either. Please add a {
"type": "node",
"request": "launch",
"name": "Launch Program",
"program": "${workspaceRoot}/test.js",
"cwd": "${workspaceRoot}",
"trace": "all"
} and post the resulting debug console output here. |
What happens if you do not press the 'terminate' button but the green 'continue' (play) button instead? |
if I press pause it crashes - let me play with above - |
Please try our experimental node2 debugger by changing the value of the |
More things you can try (only one at a time):
|
Inside the VS Code app is a script "terminateProcess.sh" in |
@weinand wow - that fixed it -- I did this:
#!/bin/bash terminateTree() { for pid in $*; do |
should I try any of the others? |
@chadbr no, it seems that you found the culprit. |
@weinand |
Aha, the pgrep on my Mac lives at |
This was happening to me (#14187) although it only killed vscode. With the 'trace' line in the launch config the time appears to be spent at
|
@lucas-natraj what is the path to your |
Same as @chadbr |
Do you know what this |
|
Could you try to change the |
That seemed to fix it. Stops debugging immediately! ...Happiness... Gratitudes!! |
@lucas-natraj @chadbr thanks a lot for helping with the investigation! |
I can easily reproduce the problem after running this |
Good to hear. |
So if I launch node and then do a If I use the The "terminateProcess.sh" script then tries to kill all those processes (which takes a long time and most kills will fail due to missing permissions). |
Cool. That explains the delay. |
The crash of VS Code or the Finder etc. occurs because brew's pgrep returns the process IDs of many (if not all) processes and the script tries to kill them all. I really mean all macOS processes! The |
Fixed in tomorrows Insiders build |
Steps to Reproduce:
On my colleges machine, vscode crashes. On my machine everything crashes (the shell, all applications, everything...) then the shell restarts.
repo gif attached... you don't see the crash because the app recording the gif gets killed...
![crashanim](https://cloud.githubusercontent.com/assets/3179452/22083145/65f62ffa-dd90-11e6-99cd-0193b4304e42.gif)
Anyone else???
The text was updated successfully, but these errors were encountered: