Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate workspace setting warnings #19627

Closed
egamma opened this issue Jan 31, 2017 · 7 comments
Closed

Duplicate workspace setting warnings #19627

egamma opened this issue Jan 31, 2017 · 7 comments
Assignees
@joaomoreno @sandy081
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view scm General SCM compound issues verified Verification succeeded
Milestone
February 2017

Comments

@egamma
Copy link
Member

egamma commented Jan 31, 2017

  • Open the workspace settings from the .vscode folder
  • Open the workspace settings using File>Preferences>Settings
  • The warnings show up twice

image
@egamma egamma added the settings-editor VS Code settings editor issues label Jan 31, 2017
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Jan 31, 2017
@sandy081 sandy081 added this to the February 2017 milestone Jan 31, 2017
@sandy081
Copy link
Member

I can reproduce this only when SCM preview is enabled.

@egamma Can you disable the SCM Preview and let me know if you are able to reproduce this?

@egamma
Copy link
Member Author

egamma commented Feb 1, 2017

@sandy081 yes I have the SCM preview enabled and cannot reproduce it otherwise.

@sandy081
Copy link
Member

sandy081 commented Feb 1, 2017

@joaomoreno Any insight what new SCM preview has to be done with this?

@joaomoreno joaomoreno self-assigned this Feb 1, 2017
@joaomoreno
Copy link
Member

Long discussions with @sandy081 @jrieken and @aeschli resulted in:

We will filter out non file: or untitled: resource markers from the problems view unless they appear in a visible editor.

@sandy081 sandy081 added error-list Problems view scm General SCM compound issues and removed settings-editor VS Code settings editor issues workbench labels Feb 1, 2017
@sandy081
Copy link
Member

sandy081 commented Feb 3, 2017

Pushed a fix to distinguish between the resources (files, git, vscode...) schemes. Default file schemes are not shown.

image

sandy081 added a commit that referenced this issue Feb 3, 2017
@sandy081
#19627 Distinguish labels in Problmes view
66ca1a1 
- Do not use scheme for files
- Use scheme for non files
sandy081 added a commit that referenced this issue Feb 6, 2017
@sandy081
Do not show schema for untitled files #19627
353f348
@sandy081
Copy link
Member

sandy081 commented Feb 6, 2017

@joaomoreno Let me know if this is sufficient enough for this issue. If so I will close it.

@joaomoreno joaomoreno mentioned this issue Feb 22, 2017
Closed
@bpasero
Copy link
Member

bpasero commented Feb 24, 2017

Verified that we show the full resource URI for problems from git resources.

@bpasero bpasero added the verified Verification succeeded label Feb 24, 2017
This was referenced Feb 28, 2017
Closed
Closed
@sandy081 sandy081 mentioned this issue Feb 28, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
February 2017
Development

No branches or pull requests
4 participants
@joaomoreno @egamma @bpasero @sandy081