Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Autosave on build #21342

Closed
BillDenton opened this issue Feb 24, 2017 · 10 comments
Closed

Feature Request: Autosave on build #21342

BillDenton opened this issue Feb 24, 2017 · 10 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code tasks Task system issues
Milestone

Comments

@BillDenton
Copy link

  • VSCode Version: Code 1.9.1 (f9d0c68, 2017-02-09T00:26:45.394Z)
  • OS Version: Windows_NT ia32 6.1.7601
  • Extensions:
Extension Author Version
language-x86-64-assembly 13xforever 2.2.9
read-only-indicator alefragnani 0.6.0
alignment annsk 0.3.0
Doxygen bbenoist 1.0.0
vscode-astyle chiehyu 0.6.2
python donjayamanne 0.5.8
EditorConfig EditorConfig 0.3.4
matlab Gimly81 0.4.0
status-bar-tasks GuardRex 0.2.0
vscode-dimmer hoovercj 2.1.0
docthis joelday 0.4.0
cpptools ms-vscode 0.10.1
vscode-clearcase OpenNingia 1.6.0
vscode-icons robertohuertasm 7.2.0
theme-cyanicpastels SamuelLampa 0.0.9
indenticator SirTori 0.2.1
vscode-hexdump slevesque 1.1.4
code-spell-checker streetsidesoftware 0.14.8
comment-snippets Tobiah 0.2.0
dark-plus-material vangware 0.2.4
change-case wmaurer 1.0.0
highlight-trailing-white-spaces ybaumes 0.0.2

Steps to Reproduce:

  1. Edit a file.
  2. Run a build command.
  3. Expect dirty files to be auto saved before running the build command.

Don't think it should be for all tasks, but probably those marked as auto-save in the tasks.json. Would be good if it could be restricted to files with in the workspace folder. I can have outside files open, e.g. notes. Perhaps something like:
"autoSave": off (default)/all/workspace

@roblourens roblourens added the feature-request Request for new features or functionality label Feb 24, 2017
@dbaeumer dbaeumer added the tasks Task system issues label Feb 27, 2017
@BillDenton
Copy link
Author

With the extension Trigger Task on Save you can trigger a build on save.

@jabooth
Copy link

jabooth commented Mar 24, 2017

@dbaeumer
Copy link
Member

dbaeumer commented Nov 9, 2017

I test this again and files are saved before a task is run.

Can you provide steps where this is not happening.

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Nov 9, 2017
@BillDenton
Copy link
Author

Just tested and I agree it does save on build. I'm not sure when this started happening or how it can be controlled, but for the default build task in 1.18.0 it works.

@dbaeumer
Copy link
Member

dbaeumer commented Nov 9, 2017

It can't be controlled right now.

@vscodebot vscodebot bot closed this as completed Nov 16, 2017
@vscodebot
Copy link

vscodebot bot commented Nov 16, 2017

This issue has been closed automatically because it needs more information and has not had recent activity. Please refer to our guidelines for filing issues. Thank you for your contributions.

@dbaeumer dbaeumer reopened this Nov 16, 2017
@dbaeumer dbaeumer removed the info-needed Issue requires more information from poster label Nov 16, 2017
@dbaeumer dbaeumer modified the milestones: On Deck, Backlog Nov 16, 2017
@alexr00
Copy link
Member

alexr00 commented Oct 22, 2018

@dbaeumer, can this be closed? Based on the discussion, save on build already happens.

@dbaeumer
Copy link
Member

@alexr00 the reason why I kept it open is that this can't be control. Currently we save for all tasks before we run them. In a perfect world we would allow users to control this on a task to task basis.

@allefeld
Copy link

allefeld commented Jan 8, 2022

In case this becomes configurable at some point, I propose to have three options:

  • save nothing
  • save active editor
  • save all

@DynConcepts
Copy link

Version 1.87.0 -- most definitely does NOT happen with .Net [.sln, .csproj] and Solution Explorer...
Checked settings as recommended above - do not seem any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code tasks Task system issues
Projects
None yet
Development

No branches or pull requests

8 participants
@roblourens @jabooth @allefeld @dbaeumer @DynConcepts @BillDenton @alexr00 and others