Tab count compare bug

[justnonamenoname]

• VSCode Version: Tested on 1.7-1.10
• OS Version: Win7

Steps to Reproduce:

1.Open
1.txt
2.txt
2.Compare
3.You will see compare is incorrect and is full different

4.If you add 1 Tab to all lines in 2.txt compare will result correct diff only in tabs

[alexdima]

@justnonamenoname

Could you please attach the two txt files on github?

Here's what I get on gta-samp.com

[justnonamenoname]

1.txt
2.txt

[alexdima]

Thank you. This appears to be a case of changes only to the whitespace. The diff editor falls back to character-by-character comparison in case the lines differ only via whitespace.

[alexdima]

I reimplemented how diffing works when trim whitespace is not ignored:

• first compute a diff with trim whitespace ignored
• then do line-level trim whitespace diffing for lines which are equal when trim whitespace is ignored.
• IMHO, this gives the best result w.r.t. what we'd expect:

before:

after: