Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot kill node process when Integrated Terminal set to Git Bash #24452

Closed
nickzelei opened this issue Apr 10, 2017 · 2 comments
Closed

Cannot kill node process when Integrated Terminal set to Git Bash #24452

nickzelei opened this issue Apr 10, 2017 · 2 comments
Assignees
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@nickzelei
Copy link

nickzelei commented Apr 10, 2017

  • VSCode Version: Code 1.11.1 (d9484d1, 2017-04-06T13:58:12.954Z)
  • OS Version: Windows_NT ia32 6.1.7601
  • Extensions:
Extension Author Version
python donjayamanne 0.6.0
EditorConfig EditorConfig 0.6.5
tslint eg2 0.11.0
vscode-docker PeterJausovec 0.0.13
vscode-icons robertohuertasm 7.5.1

Settings:
"terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe"

After running npm start and verifying my service is up and running, normally ctrl+c will kill the process. But when running in the integrated shell, this does nothing.

It works as intended in a normal git bash shell.

ctrl+c works as intended if executing something such as a npm script.

EDIT:
After repeditely opening a new integrated terminal, typing npm start, waiting for the service to start, then hitting ctrl+c, the process terminating is intermittent at best. Sometimes it kills and exits appropriately, other times I have to trash the terminal and re-open a new one.

@CherryDT
Copy link

This happens to everybody in our company as well. However it also happens to outside VSCode, I have to add. We use ConEmu, so maybe the issue exists in general with the combination of Git Bash, npm/node and non-default console emulators?

@Tyriar
Copy link
Member

Tyriar commented Apr 18, 2017

Tracking this in the upstream repo microsoft/node-pty#7

@Tyriar Tyriar closed this as completed Apr 18, 2017
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Apr 18, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants