Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown links with spaces do not work #24763

Closed
rfresow opened this issue Apr 14, 2017 · 1 comment
Closed

Markdown links with spaces do not work #24763

rfresow opened this issue Apr 14, 2017 · 1 comment
Assignees
Labels
*as-designed Described behavior is as designed markdown Markdown support issues

Comments

@rfresow
Copy link

rfresow commented Apr 14, 2017

  • VSCode Version: Code 1.11.2 (6eaebe3, 2017-04-13T08:03:11.395Z)
  • OS Version: Windows_NT ia32 10.0.15063
  • Extensions:
Extension Author Version
vscode-great-icons emmanuelbeziat 1.1.49
PowerShell ms-vscode 0.12.2

When using markdown links, links with a space in the link are not shown as links in the preview window.

Steps to Reproduce:

  1. Create a markdown file (file with extension .md)

  2. Enter text below:

    [This example does not work](C:\Program Files\Common Files\System\DirectDB.dll)
    [This example works](C:\Windows\explorer.exe)

  3. Switch to preview mode. Above examples are show as:

    image

@mjbvz mjbvz added *as-designed Described behavior is as designed markdown Markdown support issues labels Apr 14, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Apr 14, 2017

That link is not a valid markdown link, at least according to the commonmark spec

A link destination consists of [...]

  • a nonempty sequence of characters that does not include ASCII space or control characters, and includes parentheses only if (a) they are backslash-escaped or (b) they are part of a balanced pair of unescaped parentheses that is not itself inside a balanced pair of unescaped parentheses.

Try url encoding the link for starters:

[This example does not work](C:Program%20FilesCommon%20FilesSystemDirectDB.dll)

@mjbvz mjbvz closed this as completed Apr 14, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed markdown Markdown support issues
Projects
None yet
Development

No branches or pull requests

3 participants