Contrast border on first split view

[pouyakary]

• VSCode Version: Latest and greatest
• OS Version: Sierra

When you set contrast borders if you look closely they have this 1pt of pixel not-perfectness:

Also, headers get not borders at right which is also problematic:

[bpasero]

@pmkary can you share your theme changes so that I can see what happens to the header? I cannot reproduce in my simple test case:

"workbench.colorCustomizations": {
	"contrastBorder": "#ff0000"
}

The border of the entire sidebar should actually separate the header too.

I see the issue with the 1px layout glitch, good catch. Not sure if easily to fix though...

[pouyakary]

@bpasero Thanks a lot for your investigation :D

1

I can actually see that your editor has just the same problem, Look:

Before the age of workbench configs I used to manually change the CSS of the page and I know how to fix that, just check this snippet

but if you want to have more detail this the full settings:

    "workbench.colorCustomizations": {
        "editor.lineHighlightBackground": "#f2f2f2",
        "contrastBorder": "#e5e5e5",
        "peekViewEditor.background": "#E2EEFA",
        "peekViewResult.background": "#E2EEFA",
        "focusBorder": "#3778B7",
        "widget.shadow": "#cccccc",
        "editorGroup.border": "#E0E0E0",
        "editorGroupHeader.noTabsBackground": "#f1f1f1",
        "editorGroup.dropBackground": "#f1f1f1",
        "editorGroupHeader.tabsBackground": "#f1f1f1",
        "tab.inactiveBackground": "#f1f1f1",
        "tab.inactiveForeground": "#aaaaaa",
        "tab.activeForeground": "#C94824",
        "tab.border": "#f1f1f1",
        "editorWidget.background": "#f7f7f7",
        "panelTitle.activeBorder": "#B052A1",
        "titleBar.activeBackground": "#f1f1f1",
        "button.background": "#3778B7",
        "input.background": "#ffffff",
        "input.border": "#ffffff",
        "editorLineNumber.foreground": "#cccccc",
        "scrollbarSlider.background": "#DC8564",
        "scrollbarSlider.activeBackground": "#C94824",
        "scrollbarSlider.hoverBackground": "#C94824",
        "list.activeSelectionBackground": "#E2EEFA",
        "list.activeSelectionForeground": "#3778B7",
        "list.focusBackground": "#E2EEFF",
        "list.inactiveSelectionBackground": "#E2EEFA",
        "list.highlightForeground": "#3778B7",
        "inputOption.activeBorder": "#C94824",
        "activityBar.background": "#f1f1f1",
        "activityBar.foreground": "#aaaaaa",
        "activityBarBadge.background": "#C94824",
        "statusBar.background": "#3778B7",
        "statusBar.noFolderBackground": "#B052A1",
        "statusBar.debuggingBackground": "#C94824",
        "sideBarSectionHeader.background": "#f7f7f7",
        "sideBarTitle.foreground": "#A56416",
        "sideBar.background": "#f1f1f1"
    }

To be used with Kary Foundation - Light if you want the full idea.

2

About the one pixel glitch I have no idea what so ever. I think if you change the sidebar header's height it would be the simplest to fix

[bpasero]

I pushed a fix. We never actually want a contrast border for the first split view (this does not fix the reported issue but avoids it altogether).

Remains the issue with the border-right.

[pouyakary]

@bpasero thanks a lot 👍
As always the fact that you guys are so kind and caring about the issues and user request is really awesome and appreciated. Thanks a lot :D

[bpasero]

I decided to extract the other issue to #26218 so that we can close this one and verify it.

Verify:

• you are not seeing a border on top of the first split view (explorer, debug) in HC theme. Only for N > 1.