Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find Widget doesn't trap focus #2812

Closed
OlsonDev opened this issue Feb 9, 2016 · 3 comments
Closed

Find Widget doesn't trap focus #2812

OlsonDev opened this issue Feb 9, 2016 · 3 comments
Labels
editor-find Editor find operations feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone
Backlog

Comments

@OlsonDev
Copy link

OlsonDev commented Feb 9, 2016

The latest updates mention the Find Widget's tab order is improved and I agree! Thanks!

However, unlike full Visual Studio, tabbing within the widget doesn't confine the focus; eventually I end up back in my document and the only way to get back is Ctrl+F or Ctrl+H. I'm not sure if this is intentional (with all your other a11y changes) but I generally prefer the way Visual Studio does it.

Bug? Setting?
@alexdima alexdima self-assigned this Feb 9, 2016
@alexdima alexdima added the editor-find Editor find operations label Jun 26, 2016
@alexdima
Copy link
Member

alexdima commented Jul 5, 2016

This is for accessibility purposes. In our environment the only way to go to the next focusable element is via Tab and for that reason we should not trap focus -- otherwise folks who cannot use a mouse will not be able to escape the find widget.

@alexdima alexdima closed this as completed Jul 5, 2016
@OlsonDev
Copy link
Author

OlsonDev commented Jul 5, 2016 •
edited

I'm sorry, but that makes no sense. Every other IDE I've used traps focus in the find widget/panel.

I just tested with what I have installed:

  • Sublime Text - Esc key escapes the find panels. Tab toggles between "Find What:" and "Replace With:"
  • Visual Studio 2015 - Esc key escapes the find and replace panel. Tab toggles between all the fields & buttons.
  • Atom - Esc key escapes both the Find in current buffer and Find in project panels. Tab toggles between the text fields.
  • I could go on...

The Esc key should escape focus and restore focus to whatever was found.

Edited to add: Even VS Code responds properly to Esc.

@OlsonDev OlsonDev mentioned this issue Jul 5, 2016
Closed
@alexdima alexdima reopened this Aug 9, 2016
@alexdima alexdima added this to the Backlog milestone Aug 9, 2016
@alexdima alexdima added the under-discussion Issue is under discussion for relevance, priority, approach label Apr 11, 2017
@alexdima alexdima added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Nov 24, 2017
@alexdima alexdima removed their assignment Nov 24, 2017
@rebornix rebornix added the *out-of-scope Posted issue is not in scope of VS Code label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor-find Editor find operations feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@OlsonDev @rebornix @alexdima and others