Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reveal in Explorer (Windows) feature no longer bring the explorer window in front of vscode #2814

Closed
justin-romano opened this issue Feb 9, 2016 · 6 comments
Closed

Reveal in Explorer (Windows) feature no longer bring the explorer window in front of vscode #2814

justin-romano opened this issue Feb 9, 2016 · 6 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2016

Comments

@justin-romano
Copy link

"Reveal in Explorer" (Windows) feature no longer bring the explorer window in front of vscode
This works fine on vscode just not the insider version.
@justin-romano
Copy link
Author

This also no longer works for the latest vscode. Just updated

@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Feb 9, 2016
@bpasero
Copy link
Member

bpasero commented Feb 9, 2016

Looks like this is electron/electron#4349

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Feb 9, 2016
@bpasero bpasero added this to the Backlog milestone Feb 9, 2016
@bpasero bpasero modified the milestones: October 2016, Backlog Oct 26, 2016
@bpasero bpasero removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Oct 26, 2016
@bpasero bpasero added the verification-needed Verification of issue is requested label Oct 26, 2016
@bpasero
Copy link
Member

bpasero commented Oct 26, 2016

Verifier: verify on all supported OS that you can still reveal a file from the explorer to the native OS explorer and that it moves the window to the front of that native explorer.

@rebornix rebornix added verified Verification succeeded and removed verified Verification succeeded labels Oct 26, 2016
@chrmarti chrmarti added the verified Verification succeeded label Oct 27, 2016
@chrmarti
Copy link
Contributor

Works for me on Windows 10 and OS X. On Ubuntu 14.04 the native explorer does not come to the front. (Which is what it should, if I read your description to verify correctly.)

@chrmarti chrmarti reopened this Oct 27, 2016
@chrmarti chrmarti added verification-found Issue verification failed and removed verified Verification succeeded labels Oct 27, 2016
@bpasero
Copy link
Member

bpasero commented Oct 27, 2016

@chrmarti i just verified that that this did not work on Linux before and still seems to be broken on Linux. Can we still verify this one on Windows at least?

I will open a separate bug for Linux 👍

@bpasero bpasero closed this as completed Oct 27, 2016
@bpasero bpasero added verified Verification succeeded and removed verification-found Issue verification failed labels Oct 27, 2016
@chrmarti
Copy link
Contributor

I verified both Windows and OS X successfully. 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2016
Development

No branches or pull requests
5 participants
@joaomoreno @rebornix @bpasero @justin-romano @chrmarti