Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.13 is showing the logo of Github in front of .gitignore file #28300

Closed
latenssi opened this issue Jun 9, 2017 · 14 comments
Closed
Assignees

Comments

@latenssi
Copy link

latenssi commented Jun 9, 2017

  • VSCode Version: 1.13
  • OS Version: Ubuntu 17.04

Steps to Reproduce:

  1. Open Visual Studio Code
  2. Add .gitignore file to the Explorer

image

@equinusocio
Copy link

equinusocio commented Jun 9, 2017

This is related to seti-icons... that is not a curated theme icons. I think that using seti-icons as built-in icon theme was a bad choise.

@michelkaporin
Copy link
Contributor

This is not a bug.

@equinusocio
Copy link

equinusocio commented Jun 9, 2017

@michelkaporin Github issues was not made only for bugs. Yes, this is not a bug, is just a discussion about a bad and misleading ux.

Also why .travis.yml have a ! as icon (Travis CI have its own logo) and a purple color when the Travis CI brand color is green? Why docker icon use a pink color when the docker brand color is blue? and, as mentioned, .gitignore should have a git logo, not github :)

This is related to seti icons, but you should make sure that the ux is not compromised.

@michelkaporin
Copy link
Contributor

@equinusocio Now it makes sense what are you complaining about, next time please provide more information when filing an issue.

Assigning to @isidorn as it's UX-related.

@equinusocio
Copy link

@michelkaporin is not my issue :) But thanks for reopening it 👍

@michelkaporin
Copy link
Contributor

@equinusocio sorry, I meant @latenssi.

@isidorn
Copy link
Contributor

isidorn commented Jun 9, 2017

Forwarding to @aeschli as he is the owner of seti on the vscode side

@isidorn isidorn assigned aeschli and unassigned isidorn Jun 9, 2017
@kzhui125
Copy link

kzhui125 commented Jun 9, 2017

#27279

@aeschli
Copy link
Contributor

aeschli commented Jun 9, 2017

We take the Seti icon theme as-is from https://github.com/jesseweed/seti-ui and we have no plans to maintain our own variant. Please file improvement request directly against https://github.com/jesseweed/seti-ui.

Also, there are many other alternative themes available on the marketplace.

@aeschli aeschli closed this as completed Jun 9, 2017
@equinusocio
Copy link

I suggest icons from material theme..

@yfdyh000
Copy link
Contributor

jesseweed/seti-ui#341.

@jens1o
Copy link
Contributor

jens1o commented Jun 18, 2017

we have no plans to maintain our own variant

Well, seti-ui seems to be not that kind of maintained as if it is ready for this large user base, especially when you set it as default.

@aeschli
Copy link
Contributor

aeschli commented Jun 19, 2017

@jens1o From my experience, seti-ui is well maintained. But updates come in bursts. So be patient.

@jens1o
Copy link
Contributor

jens1o commented Jun 19, 2017

By maintaining, I also mean reacting to issues and so on. https://github.com/jesseweed/seti-ui/issues As you can see, it looks really empty, unfortunately.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants