Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off format on save #29335

Closed
christiancho opened this issue Jun 23, 2017 · 7 comments
Closed

Turn off format on save #29335

christiancho opened this issue Jun 23, 2017 · 7 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension

Comments

@christiancho
Copy link

I've turned off any formatOnSave settings but VSCode continues to format on save. This is throwing off my commits and other devs on my team are seeing formatting changes that sometimes will break ESLint. Please fix this. I've followed every possible set of directions to disable formatOnSave but nothing seems to be working. This is incredibly frustrating. I stopped using Atom because VSCode is much faster, but I'm rethinking and might go to WebStorm or RubyMine because of this.

  • VSCode Version: 1.13.1
  • OS Version: macOS 10.12.4
@Tyriar
Copy link
Member

Tyriar commented Jun 23, 2017

@christiancho are you sure an extension isn't doing the formatting? You can try disabling all extensions by running code --disable-extensions and see if it still reproduces.

@ericeubank-powerschool
Copy link

+1. I have disabled all extensions and have the same problem. editor.formatOnSave is ignored and formatting always occurs on my Mac. On Windows the setting works as expected.

VSCode 1.14.1
macOs 10.12.5

@rebornix
Copy link
Member

@eeubank @christiancho is there any chance that you are working on a project which has workspace setting editor.formatOnSave as true?

@rebornix rebornix added the info-needed Issue requires more information from poster label Jul 20, 2017
@christiancho
Copy link
Author

@rebornix No. I've checked my settings, both user and workspace. I disabled all extensions to see if it would help and it did. I just need to figure out which extension it is. But it's odd that nothing would appear in my settings and I can't seem to identify where it's actually coming from.

@rebornix
Copy link
Member

christiancho if I understand correctly, you are saying some extension is leading to this problem, right?

I'll suggest binary search then :)

@rebornix rebornix added *caused-by-extension Issue identified to be caused by an extension and removed info-needed Issue requires more information from poster labels Jul 20, 2017
@ericeubank-powerschool
Copy link

Ah, it was a workspace setting that was committed to our repo. It would be nice if we could see the applied setting and its source.

@rebornix
Copy link
Member

Thanks sir, problem solved.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension
Projects
None yet
Development

No branches or pull requests

5 participants