Deleting a folder and undo from Finder is not retrieving the folder in VS Code

[sandy081]

Testing #29478

• Open a Folder in VS Code
• Assume above folder has a sub folder say Sub Folder
• Go to Finder and delete Sub Folder
• Observe that it is removed from VS Code - 👍
• Undo the action in Finder by cmd+z. Folder comes back in Finder

Expected folder to come back in VS Code but not.

[bpasero]

It looks like the undo event causes a CHANGED event on the folder instead of an ADD event. There are no ADD events for the contents of the folder either. Marking as important (not for June though) because I think this is a pretty bad regression from e.g. Chokidar where this works properly.

Does not reproduce on Windows btw.

[Tyriar]

It looks like this has been fixed:

[bpasero]

@Tyriar I am still getting it and I am not 100% sure the only change that got in meanwhile (Axosoft/nsfw#24) would have an impact.

I see it on macOS by just deleting a top level folder from the workspace and the undoing that. In the video below I use single folder workspace but nsfw is enabled via settings:

Maybe worthwhile to report to NSFW? I can try to come up with a test case.

[bpasero]

I opened: Axosoft/nsfw#31

If we are unlucky then maybe we need to add manual code to detect this case and convert a MODIFIED event on a folder that was previously DELETED as CREATED (and all the children inside).

[bpasero]

Somehow this started to work for me again. Can others try too? When you use insiders nowadays you can simply open a single folder and you will get nsfw as watcher.

[bpasero]

Hm nevermind, still seeing it, but not in all cases. This is super weird...