Snippet can freeze the editor #30407

basil2style · 2017-07-11T18:25:45Z

I found out that latest VScode freezes and not opening any projects.
Reinstalling VScode 1.13 solved the problem.

VSCode Version: 1.14
OS Version: Mac sierra 10.12.5

chrmarti · 2017-07-11T19:30:26Z

Could you retry with code --verbose and append the output here?

piersadrian · 2017-07-11T19:57:23Z

Here's mine:

[main 1:56:08 PM] Starting VS Code in verbose mode
[main 1:56:08 PM] from: /Applications/Visual Studio Code.app/Contents/Resources/app
[main 1:56:08 PM] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: false,
  w: false,
  diff: false,
  d: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'unity-launch': false,
  'reuse-window': false,
  r: false,
  performance: false,
  p: false,
  'prof-startup': false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false,
  'skip-getting-started': false }
[main 1:56:09 PM] IPC#vscode-machineId
[52878:0711/135610.165590:INFO:CONSOLE(28)] "Overwriting extension <<.erb>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.165664:INFO:CONSOLE(28)] "Overwriting extension <<.rhtml>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.169747:INFO:CONSOLE(28)] "Overwriting extension <<.jsx>> to now point to mime <<text/x-jsx>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.169824:INFO:CONSOLE(28)] "Overwriting extension <<.jsx>> to now point to mime <<text/javascript>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.169864:INFO:CONSOLE(28)] "Overwriting extension <<.jsx>> to now point to mime <<text/javascript>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.169899:INFO:CONSOLE(28)] "Overwriting extension <<.erb>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.169934:INFO:CONSOLE(28)] "Overwriting extension <<.rhtml>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.169967:INFO:CONSOLE(28)] "Overwriting extension <<.erb>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.170002:INFO:CONSOLE(28)] "Overwriting extension <<.rhtml>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.494634:INFO:CONSOLE(28)] "[/Users/piersadrian/.vscode/extensions/TwentyChung.jsx-snippets-0.0.1]: The "class"-snippet very likely confuses snippet-variables and snippet-placeholders. See https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax for more details.", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.501582:INFO:CONSOLE(28)] "[/Users/piersadrian/.vscode/extensions/atefth.ruby-on-rails-snippets-0.0.1]: The "fi"-snippet very likely confuses snippet-variables and snippet-placeholders. See https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax for more details.", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[52878:0711/135610.502832:INFO:CONSOLE(28)] "[/Users/piersadrian/.vscode/extensions/atefth.ruby-on-rails-snippets-0.0.1]: The "ft"-snippet very likely confuses snippet-variables and snippet-placeholders. See https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax for more details.", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)

Looks like --disable-extensions solves this problem, so it may be a specific extension. Don't have time right now to bisect my extension list...

alexkrolick · 2017-07-11T20:08:21Z

[main 1:07:35 PM] Starting VS Code in verbose mode
[main 1:07:35 PM] from: /Applications/Visual Studio Code.app/Contents/Resources/app
[main 1:07:35 PM] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: false,
  w: false,
  diff: false,
  d: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'unity-launch': false,
  'reuse-window': false,
  r: false,
  performance: false,
  p: false,
  'prof-startup': false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false,
  'skip-getting-started': false }
[main 1:07:36 PM] IPC#vscode-machineId
[65808:0711/130736.752052:INFO:CONSOLE(28)] "Overwriting extension <<.erb>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[65808:0711/130736.752192:INFO:CONSOLE(28)] "Overwriting extension <<.rhtml>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[65808:0711/130736.754473:INFO:CONSOLE(28)] "Overwriting extension <<.js>> to now point to mime <<text/x-javascript>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[65808:0711/130736.755396:INFO:CONSOLE(28)] "Overwriting extension <<.erb>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[65808:0711/130736.755456:INFO:CONSOLE(28)] "Overwriting extension <<.rhtml>> to now point to mime <<text/x-erb>>", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[65808:0711/130736.768313:INFO:CONSOLE(28)] "[/Users/alex/.vscode/extensions/TimonVS.ReactSnippetsStandard-1.1.0]: Unknown language in `contributes.snippets.language`. Provided value: jsx", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[65808:0711/130737.257434:INFO:CONSOLE(28)] "[/Users/alex/.vscode/extensions/atefth.ruby-on-rails-snippets-0.0.1]: The "fi"-snippet very likely confuses snippet-variables and snippet-placeholders. See https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax for more details.", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[65808:0711/130737.257884:INFO:CONSOLE(28)] "[/Users/alex/.vscode/extensions/atefth.ruby-on-rails-snippets-0.0.1]: The "ft"-snippet very likely confuses snippet-variables and snippet-placeholders. See https://code.visualstudio.com/docs/editor/userdefinedsnippets#_snippet-syntax for more details.", source: file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)
[VS Code]: detected unresponsive

alexkrolick · 2017-07-11T20:23:41Z

Removing just ruby-on-rails-snippets-0.0.1 seems to fix it for me

piersadrian · 2017-07-11T20:28:23Z

@alexkrolick that did it for me, thanks!

chrmarti · 2017-07-11T23:17:27Z

@jrieken Can reproduce, the source is at https://github.com/atefth/ruby-on-rails-snippets-vs-code.

bradrich · 2017-07-12T00:19:00Z

I am not using the ruby-on-rails extension and I am also experiencing issues that are causing the application to become unresponsive. Running --verbose showed several issues that had the confuses snippet message within them. After removing those extensions, the application still becomes unresponsive, even though there are no further errors being shown. --disable-extensions does fix the problem.

Is there a way to enable extensions one-by-one until the problematic extension is found?

rebornix · 2017-07-12T00:28:09Z

@jrieken one good snippet that leads to the freeze


"con": {
   "prefix": "con",
   "body": "class ${1:${TM_FILENAME/(?:\\A|_)([A-Za-z0-9]+)(?:\\.rb)?/(?2::\\u$1)/g}} < ${2:Application}Controller\n  $3\nend",
   "description": "Create controller class",
   "scope": "source.ruby"
}

and the infinite while loop https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/snippets/electron-browser/TMSnippets.ts#L166..L171

chrmarti · 2017-07-12T00:50:33Z

@bradrich Unfortunately extensions can only be uninstalled when starting with --disable-extensions. You could list them with --list-extensions and uninstall/install from the command line (see --help). Could you post the list of installed extensions here?

karuna · 2017-07-12T01:02:00Z

@rebornix thanks. I am removing ruby.json on my config folder and it works just fine now.

karuna · 2017-07-12T01:10:45Z

@bradrich also if you have user snippets for ruby language it may cause crash.

meanphil · 2017-07-12T04:42:26Z

Removing the atefth.ruby-on-rails-snippets extension fixed it for me. i.e.:

# code  --uninstall-extension atefth.ruby-on-rails-snippets
Uninstalling atefth.ruby-on-rails-snippets...
Extension 'atefth.ruby-on-rails-snippets' was successfully uninstalled!

AlbinOS · 2017-07-12T05:24:18Z

From my side I had to remove the ruby extension and reboot my Mac and it works now.

jrieken · 2017-07-12T09:11:06Z

Fix on master and cherry picked to release/1.14.

The underlying issue is an unhappy recursion of snippets: Repeating placeholders get expanded when having no value, so ${1:foo}bar$1 will be inserted as foobarfoo. Now, if a subsequent reference of a placeholder occurs inside the first definition, like ${1:foo${VAR:bar$1baz}} our logic creates a cycle in the parse tree. Further operations then walk the tree indefinitely.

vscodebot bot added the new release label Jul 11, 2017

vscodebot bot assigned bpasero Jul 11, 2017

vscodebot bot added the workbench label Jul 11, 2017

chrmarti added snippets and removed workbench labels Jul 11, 2017

chrmarti assigned jrieken and unassigned bpasero Jul 11, 2017

chrmarti added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Jul 11, 2017

Tyriar added the important Issue identified as high-priority label Jul 12, 2017

chrmarti mentioned this issue Jul 12, 2017

1.14 Window Hangs Upon Opening #30438

Closed

chrmarti mentioned this issue Jul 12, 2017

Visual Studio Code Freezes all the time with many search results #30403

Closed

bpasero mentioned this issue Jul 12, 2017

vscode stuck #30451

Closed

jrieken changed the title ~~VScode 1.14 freezes on my Mac~~ Snippet can freeze the editor Jul 12, 2017

jrieken added the candidate Issue identified as probable candidate for fixing in the next release label Jul 12, 2017

jrieken added this to the June Recovery 2017 milestone Jul 12, 2017

jrieken closed this as completed in 96b1b69 Jul 12, 2017

jrieken added a commit that referenced this issue Jul 12, 2017

fix #30407

4b344c5

jrieken mentioned this issue Jul 12, 2017

Excessive logging of vscode.workspace.rootPath-usage causes high CPU load #30486

Closed

mjbvz mentioned this issue Jul 12, 2017

VS Code freezes on launch #30553

Closed

chrmarti mentioned this issue Jul 13, 2017

macOS Sierra 10.12.5 Update to 1.14.0 and crash #30560

Closed

mjbvz mentioned this issue Jul 13, 2017

Latest update get hang on startup, I'm unble to use it. #30571

Closed

juanarbol mentioned this issue Jul 13, 2017

V1.14.0 Does not work correctly (MacOS Sierra) #30565

Closed

dbaeumer added the verified Verification succeeded label Jul 13, 2017

chrmarti mentioned this issue Jul 13, 2017

Why the programme not responding after last update!! #30607

Closed

vscodebot bot locked and limited conversation to collaborators Nov 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Snippet can freeze the editor #30407

Snippet can freeze the editor #30407

basil2style commented Jul 11, 2017

chrmarti commented Jul 11, 2017

piersadrian commented Jul 11, 2017

alexkrolick commented Jul 11, 2017

alexkrolick commented Jul 11, 2017

piersadrian commented Jul 11, 2017

chrmarti commented Jul 11, 2017

bradrich commented Jul 12, 2017

rebornix commented Jul 12, 2017 •

edited

chrmarti commented Jul 12, 2017

karuna commented Jul 12, 2017

karuna commented Jul 12, 2017

meanphil commented Jul 12, 2017

AlbinOS commented Jul 12, 2017 •

edited

jrieken commented Jul 12, 2017 •

edited

Snippet can freeze the editor #30407

Snippet can freeze the editor #30407

Comments

basil2style commented Jul 11, 2017

chrmarti commented Jul 11, 2017

piersadrian commented Jul 11, 2017

alexkrolick commented Jul 11, 2017

alexkrolick commented Jul 11, 2017

piersadrian commented Jul 11, 2017

chrmarti commented Jul 11, 2017

bradrich commented Jul 12, 2017

rebornix commented Jul 12, 2017 • edited

chrmarti commented Jul 12, 2017

karuna commented Jul 12, 2017

karuna commented Jul 12, 2017

meanphil commented Jul 12, 2017

AlbinOS commented Jul 12, 2017 • edited

jrieken commented Jul 12, 2017 • edited

rebornix commented Jul 12, 2017 •

edited

AlbinOS commented Jul 12, 2017 •

edited

jrieken commented Jul 12, 2017 •

edited