Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic tsconfig.json tasks don't use local tsc #30754

Closed
borekb opened this issue Jul 15, 2017 · 1 comment
Closed

Automatic tsconfig.json tasks don't use local tsc #30754

borekb opened this issue Jul 15, 2017 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@borekb
Copy link

borekb commented Jul 15, 2017

VSCode 1.14 introduced autodetection and building of tsconfig.json files and as shown in that feature description, the task should correctly pick up node_modules/.bin/tsc instead of global tsc. However, I'm not seeing this. I get this:

> Executing task: tsc -p "c:\Dev\my-project\subproject\tsconfig.json" <

instead of:

> Executing task: node_modules/.bin/tsc -p "c:\Dev\my-project\subproject\tsconfig.json" <

Maybe it's because my tsconfig.jsons are nested and I don't have any project-level node_modules? My workspace looks like this:

- my-project
    - subproject
        - node_modules
        - tsconfig.json
    - subproject2
        - node_modules
        - tsconfig.json
@vscodebot vscodebot bot added the tasks Task system issues label Jul 15, 2017
@dbaeumer dbaeumer assigned mjbvz and unassigned dbaeumer Aug 2, 2017
@dbaeumer dbaeumer added typescript Typescript support issues and removed tasks Task system issues labels Aug 2, 2017
@mjbvz mjbvz added this to the November 2017 milestone Nov 9, 2017
@mjbvz mjbvz added windows VS Code on Windows issues and removed windows VS Code on Windows issues labels Nov 10, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Nov 11, 2017

Yes, we currently only check the root folder's node_modules. To fix this I think we should add logic to walk back up from the tsconfig path while checking for node_modules, or at the very least check next to the tsconfig as well

@mjbvz mjbvz added the feature-request Request for new features or functionality label Nov 14, 2017
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Nov 27, 2017
@mjbvz mjbvz closed this as completed in 47b1447 Nov 27, 2017
@roblourens roblourens added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants