Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor not rendering soft hyphen #34176

Closed
WToorenburghIntiveo opened this issue Sep 12, 2017 · 5 comments
Closed

Editor not rendering soft hyphen #34176

WToorenburghIntiveo opened this issue Sep 12, 2017 · 5 comments
Assignees
Labels
font-rendering Font rendering issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@WToorenburghIntiveo
Copy link

WToorenburghIntiveo commented Sep 12, 2017

I ran into a case where a soft hyphen had snuck into a regex expression, yet the character was not visible in the editor. It doesn't seem to render in most places, including Stack Exchange; it has only shown up for me when pasted into a terminal window like cmd.exe or terminal.app. Full disclosure: I don't know if this is behaviour as intended or not. This could also be an Electron issue.

  • VSCode Version: 1.16.0
  • OS Version: Windows 10 Pro 15063.540

Steps to Reproduce:

  1. Copy this regex expression using Ctrl+A: http://rubular.com/r/M58qyBfuxF (Link provided as it seems GitHub scrubs the soft hyphen before posting)
  2. Paste it into Code, and verify that there is no hyphen visible.
  3. Paste it into a terminal window and verify that there is a hyphen directly after the $

Reproduces without extensions: Yes
Also reproduces with both the default font and Roboto Mono

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Sep 12, 2017
@WToorenburghIntiveo
Copy link
Author

vscodebot is correct in that the integrated terminal also does not render this character, though that's not the core of the issue.

@Tyriar Tyriar added editor and removed terminal Integrated terminal issues labels Sep 14, 2017
@Tyriar Tyriar assigned alexdima and unassigned Tyriar Sep 14, 2017
@alexdima
Copy link
Member

@WToorenburghEasyMarkit This is indeed an upstream issue, all of our font rendering in the editor is done by Chromium. May I kindly ask that you open an issue at https://bugs.chromium.org/p/chromium/issues/list and link to it here.

@alexdima alexdima added upstream Issue identified as 'upstream' component related (exists outside of VS Code) font-rendering Font rendering issues and removed editor labels Sep 22, 2017
@alexdima alexdima added this to the Backlog milestone Sep 22, 2017
@WToorenburghIntiveo
Copy link
Author

@alexandrudima Thanks for the direction. Here's the issue I filed.

After looking a bit closer at some of the bugs submitted that refer to soft hyphens (the search I used), it seems like the intended behaviour is for soft hyphens to not be rendered unless they are at the end of a line. Or, at least, it seems as though soft hyphens not being visible at all times is not unintended.

@alexdima
Copy link
Member

This is an upstream issue (possibly within Chromium), and there are no known workarounds that we could implement on our side. This means there is no possible code change for us to do in VS Code sources to improve things.

To keep the number of issues in our inbox at a manageable level, we’re closing issues that have been on the backlog for a long time but haven’t gained traction or that are not actionable. Thank you for your time and understanding.

@WToorenburghIntiveo
Copy link
Author

Understandable! Thanks for the communication. Here's hoping the Chromium issue I filed gets some further attention.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
font-rendering Font rendering issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants