Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the new CLA system #34239

Closed
kieferrm opened this issue Sep 12, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@kieferrm
Copy link
Contributor

commented Sep 12, 2017

The CLA system for this repository is kindly developed and maintained my Microsoft's Open Source team. Kudos to them to take care of this! Over the last weeks, they have been busy improving the CLA checking and signing processes and we are ready to adopt the new system.

Here is what the new system is all about, in MS Open Source team's @jeffmcaffer's own words:


The new CLA system has the following improvements:

  • Status checks – The need for/and completion of a CLA is captured in GitHub PR status checks. As such they can be used to drive behaviors such as blocking the merge of a PR until the CLA is signed. This removes the guess work and potential for error from collaborating with contributors.
  • Chattiness – By using status checks the system removes the need for PR comments and labels, in turn removing nearly all the CLA-related clutter from the PR interaction.
  • Click to agree – Contributors agree to the CLA by completing a simple web form rather than working through a DocuSign process.
  • No confirmation lag – Completed CLAs are now instantly confirmed based on the user’s GitHub credentials. No more waiting for manual validation and confirmation.
  • Based on open source – We have adopted an existing open source solution (https://cla-assistant.io/) and are contributing heavily to its evolution. We both benefit from the innovation of the SAP team and grow the community. Go figure!

Notes:

  • The rules around CLAs have NOT changed.
  • As noted above, labels are no longer being used to indicate the need for or completion of a CLA. That information is conveyed in the status check along with any other validations you may have in place. While this does remove the ability to search for PRs with a particular CLA disposition, we have worked with a number of teams and determined that that search is seldom if ever used and that the reduction in clutter is well worth that tradeoff. If you feel otherwise, please let us know by email to opensource@microsoft.com.
  • We are working on performance improvement that more quickly effect the appropriate status changes once a contributor signs the CLA. The new system is on par with the old but we driving to make it even faster.

What could go wrong:

  • Members of the Microsoft Organization being asked to sign the CLA – All Microsoft employees who have linked their Microsoft and GitHub ids are automatically added to the system. If you are a Microsoft FTE or vendor and are being asked to sign the CLA, please check that you have linked the account you are using for the PR. If you have, please contact opensource@microsoft.com.
  • Contributors being asked to sign again – All existing signed CLAs have been primed into the new system. It is possible that a previously signed CLA got missed as some of the data was incomplete. While we expect to keep the new and old systems in sync during the transition, it is possible that some entries will get dropped. If this happens, please both ask the contributor to sign again (with appropriate apologies) and let us know via email to opensource@microsoft.com.

@kieferrm kieferrm added the plan-item label Sep 12, 2017

@kieferrm kieferrm added this to the September 2017 milestone Sep 12, 2017

@kieferrm kieferrm self-assigned this Sep 12, 2017

@kieferrm kieferrm referenced this issue Sep 12, 2017

Closed

Iteration Plan for September 2017 #34160

45 of 48 tasks complete
@MichaelTsengZL

This comment has been minimized.

Copy link

commented Sep 12, 2017

All the VSCode related repositories in the Microsoft Organization are using the new CLA system now.
Since we are just shifting to the new CLA system, there may be some ambiguity between the previous CLA system comments and new CLA system status for the previously opened pull requests. The status is the correct one to follow.

@kieferrm kieferrm closed this Sep 18, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.