Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: collapse but keep roots expanded #34685

Closed
bpasero opened this issue Sep 20, 2017 · 4 comments · Fixed by #37451
Closed

Search: collapse but keep roots expanded #34685

bpasero opened this issue Sep 20, 2017 · 4 comments · Fixed by #37451
Assignees
@roblourens
Labels
feature-request Request for new features or functionality search Search widget and operation issues verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone
November 2017

Comments

@bpasero
Copy link
Member

bpasero commented Sep 20, 2017

One pattern I am seeing myself doing a lot is invoking the "Collapse" action on the search viewlet and now that I have multi root results, I see no results until I expand a root:

image

Could we maybe collapse all but leave the roots expanded? Or, upon first collapse call we do that and upon the second we collapse also the roots?
@bpasero bpasero added the search Search widget and operation issues label Sep 20, 2017
@roblourens
Copy link
Member

Or, upon first collapse call we do that and upon the second we collapse also the roots?

hmmm...

@roblourens roblourens added the feature-request Request for new features or functionality label Sep 20, 2017
@roblourens roblourens added this to the Backlog milestone Sep 20, 2017
@bpasero
Copy link
Member Author

bpasero commented Oct 25, 2017

This still annoys me a lot, especially if the results are only coming from one folder:

image

@roblourens roblourens modified the milestones: Backlog, October 2017 Oct 25, 2017
@roblourens
Copy link
Member

Agreed, and there should be an external PR incoming for this. If not I'll fix it...

RMacfarlane pushed a commit to RMacfarlane/vscode that referenced this issue Nov 1, 2017
microsoft#34685 Collapse search results one level at a time
263575c
@RMacfarlane RMacfarlane mentioned this issue Nov 1, 2017
Merged
roblourens added a commit that referenced this issue Nov 4, 2017
@roblourens
Merge pull request #37451 from RMacfarlane/ramacfar-collapse
829731d 
#34685 Collapse search results one level at a time
@bpasero
Copy link
Member Author

bpasero commented Nov 5, 2017

@roblourens this behaves very nice now, thanks!

@bpasero bpasero added the workbench-multiroot Multi-root (multiple folders) issues label Nov 5, 2017
@alexdima alexdima added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
feature-request Request for new features or functionality search Search widget and operation issues verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Milestone
November 2017
Development

Successfully merging a pull request may close this issue.

#34685 Collapse search results one level at a time RMacfarlane/vscode
3 participants
@roblourens @bpasero @alexdima