Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: With NVDA, the second to last line of this text breaks. #34779

Closed
derekriemer opened this issue Sep 21, 2017 · 2 comments
Closed
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@derekriemer
Copy link

  • VSCode Version: Code - Insiders 1.17.0-insider (f7962f0, 2017-09-20T05:24:33.599Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
python don 0.7.0
cpptools ms- 0.12.4
incremental-search sie 0.2.1
code-spell-checker str 1.4.0

Steps to Reproduce:

  1. turn on NVDA.
  2. Paste this into code, in a empty document. This code was taken from an NVDA pull request I'm working on.
    #IAccProcServer.py:
    #A part of NonVisual Desktop Access (NVDA)
    #Copyright (C) 2017 NV Access Limited, Derek Riemer
    #This file is covered by the GNU General Public License.
    #See the file COPYING for more details.
    
    """Implementation of IAccProcServer, so that customization of a wx control can be done very fast."""
    
    from logHandler import log
    from  comtypes.automation import VT_EMPTY
    from  comtypes import GUID, COMObject
    from comInterfaces.Accessibility import IAccPropServer
    
    #These are the GUIDS for IAccessible properties we can override.
    #Use these to look up the GUID needed when implementing a server.
    #These are taken from oleacc.h (oleacc.idl has them too).
    #Number of digits Format: "{8-4-4-4-12}"
    PROPID_ACC_NAME = GUID("{608d3df8-8128-4aa7-a428-f55e49267291}")
    PROPID_ACC_VALUE             = GUID("{123fe443-211a-4615-9527-c45a7e93717a}")
    PROPID_ACC_DESCRIPTION = GUID("{4d48dfe4-bd3f-491f-a648-492d6f20c588}")
    PROPID_ACC_ROLE = GUID("{CB905FF2-7BD1-4C05-B3C8-E6C241364D70}")
    
  3. go to the PROPID_ACC_DESCRIPTION = GUID("{4d48dfe4-bd3f-491f-a648-492d6f20c588}") line.
  4. Now, go to the end of the line, and press backspace.

Expected: The last character is announced as it is deleted.
Actual: Nothing speaks, but the character is deleted.

Reproduces without extensions: Yes

@vscodebot vscodebot bot added insiders accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Sep 21, 2017
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug and removed insiders labels Sep 26, 2017
@alexdima alexdima added this to the September 2017 milestone Sep 26, 2017
@alexdima
Copy link
Member

@derekriemer Thank you! Nice catch!

@derekriemer
Copy link
Author

wo, that was fast!

@isidorn isidorn added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants