Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet don't clear '<' when type <tag then press tab <<tag></tag> #34906

Closed
gladx opened this issue Sep 24, 2017 · 4 comments
Closed

Emmet don't clear '<' when type <tag then press tab <<tag></tag> #34906

gladx opened this issue Sep 24, 2017 · 4 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone
September 2017

Comments

@gladx
Copy link

gladx commented Sep 24, 2017

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:26:20.018Z)
  • OS Version: Linux x64 4.10.0-33-generic
  • Extensions:
Extension Author (truncated) Version
beautify Hoo 1.1.1
crane Hvy 0.3.8
code-settings-sync Sha 2.8.3
quokka-vscode Wal 1.0.66
html-snippets abu 0.1.0
vscode-twig-pack baj 1.0.0
vscode-intelephense-client bme 0.7.2
phplt cao 1.1.0
path-intellisense chr 1.4.2
goto-documentation cxf 0.0.1
vscode-html-css ecm 0.1.8
prettier-vscode esb 0.23.1
php-debug fel 1.11.1
php-intellisense fel 1.5.1
auto-close-tag for 0.5.0
yii2-snippets ima 0.0.9
Angular2 joh 2.7.0
php-cs-fixer jun 0.1.43
php-symbols lin 2.1.0
js-atom-grammar ms- 0.1.13
php-docblocker nei 1.2.0
advanced-new-file pat 0.5.0
highlight-matching-tag vin 0.4.4
twig wha 1.0.2
JavaScriptSnippets xab 1.4.1
vscode-pomodoro yah 1.0.3

Steps to Reproduce:

1.when write any html tag for example start with <div
2. and press tab to complete tag
3- create <<div></div> :-( expected <div> </div>

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the emmet Emmet related issues label Sep 24, 2017
@ramya-rao-a
Copy link
Contributor

I can't repro...

htmlemmet

Can you try again with extensions disabled to ensure none of the extensions are interfering? Run code --disable-extensions

@ramya-rao-a ramya-rao-a added the info-needed Issue requires more information from poster label Sep 25, 2017
@gladx
Copy link
Author

gladx commented Sep 25, 2017

html
run code --disable-extensions in html document
php
and in php document

Code.mkv.zip
a screen cast show problem code.mkv

@yume-chan yume-chan mentioned this issue Sep 25, 2017
Closed
@yume-chan
Copy link
Contributor

yume-chan commented Sep 25, 2017 •
edited
Loading

I can reproduce this in both 1.16.1 and 1.17-insiders.

Press < A Backspace A Enter in a HTML file.

ramya-rao-a added a commit to microsoft/vscode-emmet-helper that referenced this issue Sep 25, 2017
@ramya-rao-a
Dont treat open tags as abbreviation microsoft/vscode#34906
c4ac175
@ramya-rao-a ramya-rao-a added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster new release labels Sep 25, 2017
@ramya-rao-a ramya-rao-a added this to the September 2017 milestone Sep 25, 2017
ramya-rao-a added a commit that referenced this issue Sep 25, 2017
@ramya-rao-a
Pull fixes for #33994 and #34906
5ae1dc4
@ramya-rao-a
Copy link
Contributor

Thanks @gladx and @yume-chan I can repro now.

Pushed a fix to not show emmet in completions when what is typed is an open tag

Note to verifiers

  • Type <html or < any html tag
  • Delete last char and type it again to trigger emmet completions or press ESC and manually trigger suggestions by Ctrl+Space
  • No emmet suggestions should appear

@mjbvz mjbvz added the verified Verification succeeded label Sep 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
4 participants
@yume-chan @gladx @mjbvz @ramya-rao-a