Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Code insiders source control blank #37221

Closed
JohnstonCode opened this issue Oct 31, 2017 · 10 comments
Closed

API: Code insiders source control blank #37221

JohnstonCode opened this issue Oct 31, 2017 · 10 comments
Assignees
@joaomoreno
Labels
api bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Milestone
October 2017

Comments

@JohnstonCode
Copy link

  • VSCode Version: 1.18.0-insider Commit 81cca6c
  • OS Version: Fedora 25

While making my svn extension multi-root aware the source control view is blank. The changes do get added to the resourceStates as I can dump them out.

The changes I have made work in VSCode Version 1.17.2 without any issues.

Steps to Reproduce:

  1. Open an svn project with changes.
  2. source control is blank and there is no badge count
@vscodebot vscodebot bot added the git GIT issues label Oct 31, 2017
@JohnstonCode JohnstonCode mentioned this issue Oct 31, 2017
Closed
@joaomoreno
Copy link
Member

Can you show me the source code? In the exact version of what you are seeing?

@joaomoreno joaomoreno added info-needed Issue requires more information from poster api scm General SCM compound issues and removed git GIT issues labels Oct 31, 2017
@joaomoreno joaomoreno changed the title Code insiders source control blank API: Code insiders source control blank Oct 31, 2017
@JohnstonCode
Copy link
Author

Sure the source code is here

@joaomoreno
Copy link
Member

joaomoreno commented Nov 1, 2017 •
edited
Loading

Oh wait. I just realised you said this works fine in 1.17.2. But it doesn't in 1.18.0? Did I get that right?

@JohnstonCode
Copy link
Author

Yes, thats correct.

@joaomoreno
Copy link
Member

Yup I can easily reproduce, I'll take a deeper look...

@joaomoreno joaomoreno modified the milestones: Backlog, October 2017 Nov 1, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Nov 1, 2017
@JohnstonCode
Copy link
Author

If it helps im using todays release 2ab10d5 and the problem is even worse. The source control view is completly blank now.

joaomoreno added a commit that referenced this issue Nov 1, 2017
@joaomoreno
warn about uncaught exceptions inside LazyPromise
93338c6 
related to #37221
@joaomoreno
Copy link
Member

@jrieken NPE: cadcedc#diff-a1d58c39a5da1115d2ed23311e181142L197

@joaomoreno
Copy link
Member

@JohnstonCode Great catch, thanks! Pushed a fix for it.

@JohnstonCode
Copy link
Author

No Problem

@jrieken
Copy link
Member

jrieken commented Nov 1, 2017

Nice!

@jrieken jrieken added the verified Verification succeeded label Nov 3, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
api bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @JohnstonCode