ConfigurationModel is slow

[jrieken]

Related to #34353 and #34282. When you profile start and look at the time spend in the configuration service you'll notice that it's still very slow.

Paste require('vs/base/node/startupTimers').ticks().forEach(tick => console.log(tick.name, tick.duration)) in the dev-tools-console and see that ~100ms is spend in building/merging/deduping the configuration model.

Apart from clone it also seems that a lot of time is spend in arrays#distinct which as a potential runtime of O(n2)

[sandy081]

@jrieken Thanks for the report.

May I know if it is slower than before ?

[jrieken]

May I know if it is slower than before ?

No clue, you can measure it with an old version of VS Code

[sandy081]

This is the new picture after doing following improvements:

• Merge, clone and freeze only when the configuration is requested.
• Fix from @jrieken - ConfigAwareContext is slow  #37539
• Register and trigger configuration and default configurations all at a time.
• Merge user configuration service and workspace configuration service to remove duplicate merges and triggering.