Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not active debuggers when creating debug env drop down menu #37929

Closed
weinand opened this issue Nov 9, 2017 · 7 comments

Comments

@weinand
Copy link
Member

commented Nov 9, 2017

Problem:

  • install Java debugger
  • open a folder with no launch.json
  • switch to debug view and press gear button

Observe:
it looks like nothing is happening but in reality Java is initialising and starting Java language server. After a long time the debug env drop down appears.

Analysis:
Building the debug env drop down seems to activate all debug extensions.

Solution:
We should try to build the debug env drop down list only from declarative information found in the package.json. No debugger extensions should be activated for this.

/cc @aeschli

@weinand weinand added bug debug labels Nov 9, 2017

@weinand weinand added this to the November 2017 milestone Nov 9, 2017

@weinand weinand removed their assignment Nov 30, 2017

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2017

I acknowledge the bug, however due to how the code is structured on my side this would require a refactoring in the guessAdapter method which I am not so keen on doing because we have better fine grained events as a workaround. Thus pushing this to the backlog

@isidorn

This comment has been minimized.

Copy link
Contributor

commented May 11, 2018

Fixed in latest via 42512b2

@isidorn isidorn closed this May 11, 2018

@isidorn

This comment has been minimized.

Copy link
Contributor

commented May 11, 2018

My mistake, acutally this is not fixed via that commit

@kyliel

This comment has been minimized.

Copy link

commented Aug 28, 2018

How's going on for this bug? One more customer reported that they still see Java language server running on the bottom when developing a python file. It is strange. Thank you.
microsoft/vscode-java-debug#238

@weinand weinand modified the milestones: On Deck, September 2018 Aug 28, 2018

isidorn added a commit that referenced this issue Sep 26, 2018

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2018

I have cleaned up the activation events and this is now fixed via #59464

However since this change is a bit delicate I would prefer to have the whole milestone to self host on it in insiders before we release it in stable. Due to that I will merge the PR in 4 days, so it is included in the next week insider, however it will be only in the october stable release (in a month).

@isidorn isidorn modified the milestones: September 2018, October 2018 Sep 26, 2018

JimiC added a commit to JimiC/vscode that referenced this issue Oct 5, 2018

@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Nov 2, 2018

Using our process explorer, I still see the java debugger extension being activated in this case. There is also a slight delay when clicking on the gear

@mjbvz mjbvz reopened this Nov 2, 2018

@isidorn isidorn modified the milestones: October 2018, November 2018 Nov 2, 2018

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2018

After looking deeper into this, it is fine since the java debugger is activating onDebugInitialConfigurations since it is providing the initial configurations dynamically. Thus we have to activate it since we do not know which debugger the user will chose.

https://github.com/Microsoft/vscode-java-debug/blob/14fe7d5d0d41a397eaff4f3701860653850058fb/package.json#L31

Closing as designed.

To verify: debug a node program, and verify that the java extension does not get activated

@isidorn isidorn closed this Nov 6, 2018

@roblourens roblourens added the verified label Dec 5, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.