Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

power mode extension broken in Insiders, are others affected? #39259

Closed
chrisdias opened this issue Nov 28, 2017 · 2 comments
Closed

power mode extension broken in Insiders, are others affected? #39259

chrisdias opened this issue Nov 28, 2017 · 2 comments
Assignees
@alexdima
Labels
*as-designed Described behavior is as designed under-discussion Issue is under discussion for relevance, priority, approach
Milestone
November 2017

Comments

@chrisdias
Copy link
Member

Insiders on MacOS
Version 1.19.0-insider (1.19.0-insider)
commit af232487ebcdc9758da537ea9a58977c373bc2be
2017-11-28T06:03:32.906Z

The Power Mode extension is broken in Insiders, see: hoovercj/vscode-power-mode#20

I'm opening an issue here because something changed in VS Code recently that causes the extension to not work properly, and perhaps that change will affect other extensions.

To repro:
Install the Power Mode extension
enable it through the powermode.enabled = true setting
start typing

result: "explosions" only occur at start of line
expected: as in stable, explosions track the cursor
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Nov 28, 2017
@kieferrm kieferrm added api and removed extensions Issues concerning extensions labels Nov 28, 2017
@jrieken jrieken removed the api label Nov 29, 2017
@jrieken jrieken assigned alexdima and unassigned jrieken Nov 29, 2017
@alexdima
Copy link
Member

Yes, I changed how inline decorations are rendered for #37401

It might affect rendering scenarios outside of our decorations scope (i.e. hacks).

@alexdima alexdima added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 29, 2017
@alexdima alexdima added this to the November 2017 milestone Nov 29, 2017
@alexdima alexdima closed this as completed Dec 7, 2017
@alexdima alexdima added the *as-designed Described behavior is as designed label Dec 7, 2017
This was referenced Jan 12, 2018
Closed
Merged
@hoovercj
Copy link
Member

Power mode is definitely a hack and I anticipate it will break again in the future, but thanks for letting me know when it does! It is fixed (for now) in version 2.1.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
*as-designed Described behavior is as designed under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
5 participants
@chrisdias @jrieken @hoovercj @kieferrm @alexdima