Ctrl hover shows a less useful hint when fn opening brace is on a new line

[bmewburn]

The textDocument/definition response range is that of the entire symbol definition (header + body) in both cases.

[roblourens]

@mjbvz Problem is not with PHP, is with the hover widget and rendering these LSP messages. Who owns that?

[alexdima]

This is the jump to definition hover.

[bpasero]

I think the current incarnation of that hover came in via 34cdf9f

[faso]

I'd like to take this one

[jrieken]

It's yours @faso. The code is here and I am slightly embarrassed that there are no tests: https://github.com/Microsoft/vscode/blob/e7bc65ad3e1d5cf5b32054d86cbba6e2fef05af3/src/vs/editor/contrib/goToDeclaration/goToDeclarationMouse.ts#L144

It's a heuristic that does the following: Once the target document is resolved (textEditorModel) we try to find "good chunk to preview". It starts at the (start) line of the reference and walks downwards until it finds a line with the same indentation. That works ok for foo() { but not for foo()\n{... I think a nicer model would be to look for balanced brackets, e.g. continue until you find the right }. Maybe a combination of both approaches because often references are to fields/constants and not bracket-blocks (like functions et al).
Hope I didn't scare you, feel free to ask questions.

[zeerorg]

If this issue is open I would like to take this up.
I also looked around the code pointed to by @jrieken and tried to figure what was going on.
As suggested, we can improve this by

1. Differentiating between variables and functions/classes
2. For functions/Classes scanning the lines and using something like a simple stack to figure out where the scope ends.

[jrieken]

@zeerorg it is up to @faso who put his stick into the ground first (albeit quite a while back). Still, be aware of us not knowing the semantics of sources. That makes assumptions like 'for a variable do this', 'for a method do that' very hard.

[natiiix]

Not sure if this is entirely related to the issue, but I couldn't find a more appropriate one. The behavior when hovering over a variable is a little confusing at first sight, as pointed out by @zeerorg.

Right now it simply reads the next non-whitespace line of code, which has usually nothing at all to do with the variable itself. See the attached image for reference.

The same problem seems to occur for C# inline-defined (not sure what is the official name) functions.

An idea for a possible fix for C-like languages (admittedly not very robust):
If the symbol name is followed by =, look for ;, otherwise look for }.
Of course, it must not appear inside of a string literal or a nested scope.
This would theoretically solve the initial problem, the problem with variable definitions and the problem with inline-defined functions. It would also work for code with no indentation.
It should be possible to come up with a similar rule for indentation-based language such as Python.

[jrieken]

fixed via #52506