Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL+C doesn't copy all if last lines are folded #41744

Closed
amgalan81mn opened this issue Jan 17, 2018 · 8 comments
Closed

CTRL+C doesn't copy all if last lines are folded #41744

amgalan81mn opened this issue Jan 17, 2018 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-clipboard Editor clipboard issues editor-folding Editor code folding issues verified Verification succeeded
Milestone

Comments

@amgalan81mn
Copy link

amgalan81mn commented Jan 17, 2018

Example from #83985 (edited by @aeschli):

  • create a markdown document from the content below
  • collapse all (Ctrl+K, Ctrl+0)
  • Ctrl+A to select all,

-> the copied text does not include the WaveRecord onwards, it is only copied as far as the #Data Structures (line 6)

# (APIBlueprint document)

# Introduction
This is my introduction

# Data Structures

## WaveRecord (object)

+ mailingId: 103 (number, required) - The mailing identifier.
+ waveId: 253 (number, required) - The wave identifier.
+ name: `Initial Test` (string, required) - The wave name.
+ portion: 500 (number, required) - The wave portion of the mailing (1 - 10000), 10000 represents the whole mailing.
+ status: `Processed` (enum, required) - The wave status.
    + Members
        + `Draft` - The wave has been created but not queued.
        + `Processed` - The wave has been processed.
        + `Queued` - The wave has been queued but not processed.
+ createDate: `2016-07-30T16:28:22` (string, required) - The create date (UTC).
+ modifyDate: `2016-07-31T07:49:18` (string, required) - The last modified date (UTC).
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Jan 17, 2018
@jrieken jrieken added the info-needed Issue requires more information from poster label Jan 17, 2018
@jrieken
Copy link
Member

jrieken commented Jan 17, 2018

ctrl+a where?

@amgalan81mn
Copy link
Author

amgalan81mn commented Jan 24, 2018 via email

@aeschli
Copy link
Contributor

aeschli commented Jan 26, 2018

@amgalan81mn Can you please add the screenshots that show the problem?

@amgalan81mn
Copy link
Author

amgalan81mn commented Jan 28, 2018 via email

@amgalan81mn
Copy link
Author

amgalan81mn commented Jan 29, 2018 via email

@aeschli aeschli added editor-folding Editor code folding issues bug Issue identified by VS Code Team member as probable bug and removed extensions Issues concerning extensions info-needed Issue requires more information from poster labels Jan 29, 2018
@aeschli aeschli changed the title CTRL+A, cant select last collapsed rows [folding] CTRL+A doesn't select last folded line in python Jan 29, 2018
@amgalan81mn
Copy link
Author

amgalan81mn commented Jan 31, 2018 via email

@aeschli aeschli added this to the Backlog milestone Sep 17, 2018
@AliShug
Copy link

AliShug commented Mar 6, 2019

I also hit this problem. Pretty easy to repro

@aeschli aeschli changed the title [folding] CTRL+A doesn't select last folded line in python [folding] CTRL+A doesn't select all if last lines are folded Nov 6, 2019
@aeschli
Copy link
Contributor

aeschli commented Nov 6, 2019

IMo the problem is with convertModelRangeToViewRange:

public convertModelRangeToViewRange(modelRange: Range): Range {
.

When converting a range both start and end positions are converted to the last visible line.

@aeschli aeschli assigned alexdima and unassigned aeschli Nov 6, 2019
@alexdima alexdima changed the title [folding] CTRL+A doesn't select all if last lines are folded [folding] CTRL+C doesn't copy all if last lines are folded Nov 6, 2019
@alexdima alexdima changed the title [folding] CTRL+C doesn't copy all if last lines are folded CTRL+C doesn't copy all if last lines are folded Nov 6, 2019
@alexdima alexdima added the editor-clipboard Editor clipboard issues label Nov 6, 2019
@alexdima alexdima modified the milestones: Backlog, January 2020 Jan 19, 2020
@rebornix rebornix added the verified Verification succeeded label Jan 29, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-clipboard Editor clipboard issues editor-folding Editor code folding issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants