Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#region and #endregion last state is not saved #42217

Closed
ryanfog opened this issue Jan 26, 2018 · 12 comments
Closed

#region and #endregion last state is not saved #42217

ryanfog opened this issue Jan 26, 2018 · 12 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@ryanfog
Copy link

ryanfog commented Jan 26, 2018

  • VSCode Version: Code 1.19.3 (7c4205b, 2018-01-25T10:36:34.867Z)
  • OS Version: Windows_NT x64 10.0.16299
  • Extensions:
Extension Author (truncated) Version
PowerShell ms- 1.5.1
team ms- 1.122.0

#region and #endregion last state is not saved aka collapsed or not collapsed. I tend to save my scripts with the region collapsed down and when I re-open a script they are all expanded again.

Reproduces without extensions: Yes/No

@aeschli
Copy link
Contributor

aeschli commented Jan 29, 2018

I can't reproduce that.

  • open a file, collapse a #region section in it
  • close the editor
  • open the file again in the editor: Observe that the #region is still collapsed

@ryanfog Can you give your steps and find out what's special about your setup?

@aeschli aeschli added the info-needed Issue requires more information from poster label Jan 29, 2018
@vscodebot vscodebot bot closed this as completed Feb 5, 2018
@vscodebot
Copy link

vscodebot bot commented Feb 5, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@ryanfog
Copy link
Author

ryanfog commented Feb 5, 2018

@aeschli
Copy link
Contributor

aeschli commented Feb 7, 2018

Thanks for the document. A lot of screenshots and I'm not sure what each one wants to show.
Can you give some more details about what you do and where you see the issue.
Please paste the relevant screenshot directly in this issue (paste in the comment section), so that no external program is needed to open the document.
́

@aeschli aeschli reopened this Feb 7, 2018
@ryanfog
Copy link
Author

ryanfog commented Feb 7, 2018

I wanted to show via a PSR that I collapsed the regions click save, closed visual code and re-opened it and all the regions were expanded and not collapsed as expected.

@aeschli
Copy link
Contributor

aeschli commented Feb 7, 2018

Hm that's strange. You just close vscode and reopen it and reopen the same file.
When I do that, I get the folding restored to what it was before.
What about the cursor position? Is it correctly restored?

@ryanfog
Copy link
Author

ryanfog commented Feb 7, 2018

After some further testing the issue appears to be narrowed down a little more... create a region, collapse the region save the file, keep the file loaded but close visual code. The regions are expanded upon reopening visual code. If you close (x) the file in visual code before closing visual code it acts as expected.

@aeschli
Copy link
Contributor

aeschli commented Mar 1, 2018

With ' keep the file loaded' you mean keep the editor tab open?

@ryanfog
Copy link
Author

ryanfog commented Mar 1, 2018

yes exactly.

@ghost
Copy link

ghost commented May 31, 2018

same issues and it doesn't save the cursor position either, that's so annoying...

@aeschli
Copy link
Contributor

aeschli commented Sep 17, 2018

I need more details about what you do and where you see the issue.
Please paste the relevant screenshot directly in this issue (paste in the comment section), so that no external program is needed to open the document.

@aeschli aeschli closed this as completed Sep 17, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
@aeschli aeschli reopened this Jan 28, 2019
@microsoft microsoft unlocked this conversation Jan 28, 2019
@vscodebot vscodebot bot closed this as completed Feb 4, 2019
@vscodebot
Copy link

vscodebot bot commented Feb 4, 2019

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants