Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] Allow folding block comment that starts in the middle of the line #42287

Open
mhermher opened this issue Jan 29, 2018 · 3 comments
Open
Assignees
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality
Milestone

Comments

@mhermher
Copy link

mhermher commented Jan 29, 2018

An additional request on top of now-closed feature-request 11524.

I sometimes like to write my block comments in this form:

let someflag : boolean = false;/*
    this flag does blah blah
    blah blah blah blah*/
let somethingelse : string;

So that folding that comment completely removes it from view outside of that trailing start marker. However, the implementation to feature-request 11524 does not detect this type of block comment and only seems to pick up on block comments started on their own new line. I am not sure how popular that style of commenting is, but it would help me a lot of it could be picked up by that feature.

Thanks.

@aeschli
Copy link
Contributor

aeschli commented Jan 29, 2018

Hm, difficult with what we have:

@aeschli aeschli changed the title Collapse block comment when started not as new line Allow folding block comment that starts in the middle of the line Jan 29, 2018
@aeschli aeschli added this to the Backlog milestone Jan 29, 2018
@aeschli aeschli added the editor-folding Editor code folding issues label Jan 29, 2018
@mhermher
Copy link
Author

Hi Martin. Thanks for the reply. Sorry about the markup in my example, but lines 2 and 3 above should be indented, but they didn't come out right in the GitHub comment editor thing. If indented properly, the code does actually fold if you click the +/- markers in the left margin. My issue was specifically with the auto-folding for comments feature (cmd K cmd /), which does not pick up this kind of commenting.

@aeschli
Copy link
Contributor

aeschli commented Jan 29, 2018

I fixed your comment (using the triple backtick).

Ok, I see, I guess for this case we could make 'fold comment' work.

@aeschli aeschli added the feature-request Request for new features or functionality label Feb 23, 2018
@aeschli aeschli changed the title Allow folding block comment that starts in the middle of the line [folding] Allow folding block comment that starts in the middle of the line Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants