Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue reporter various accessibility concerns #42570

Closed
Tyriar opened this issue Jan 30, 2018 · 1 comment
Closed

Issue reporter various accessibility concerns #42570

Tyriar opened this issue Jan 30, 2018 · 1 comment
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 30, 2018 •
edited

Issue Type

Bug

#42351

Description

I didn't actually test with a screen reader as I tested on Linux but I have the following concerns:

  • "Please complete the form in English." appears to only be exposed to screen readers?
  • The #description-validation-error looks like it should have role="alert" to alert screen readers

VS Code Info

VS Code version: Code - Insiders 1.20.0-insider (8cac1ac, 2018-01-30T17:28:33.081Z)
OS version: Linux x64 4.13.0-31-generic

Reproduces only with extensions
@RMacfarlane
Copy link
Contributor

As discussed, "Please complete the form in English" has display: none, so I'm only adding the role="alert"

@RMacfarlane RMacfarlane added this to the January 2018 milestone Feb 1, 2018
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Feb 1, 2018
@octref octref added the verified Verification succeeded label Feb 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
3 participants
@Tyriar @RMacfarlane @octref