-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editor.tokenColorCustomizations not applying font style #42939
Comments
Can you try to set |
You know, I just found that out as you typed the comment. Thank you! I feel this whole area is lacking in documentation, as the hint if you type an incorrect value doesn't mention leaving it empty to override it. |
Seems logical to me to override only specified properties. Validation probably disabled because values can be compound: Some documentation is there: |
Probably can be validated against list: ""
"bold"
"underline"
"italic"
"bold italic"
"italic bold"
"bold underline"
"underline bold"
"italic underline"
"underline italic"
"bold italic underline"
"italic bold underline"
"underline bold italic"
"bold underline italic"
"italic underline bold"
"underline italic bold" |
@aeschli For the schema considerations. |
Thanks all. |
Why can't we change the fontFamily here? For example, I'd like to change the comparison operator to font Fira Code in order to turn on Ligatures just in this spot.
|
(5 theme extensions excluded)
I am not seeing the fontStyle changes I am trying to apply. The Theme I use (Nord Extra Dark) has applied italics in some places, and I am trying to set them to normal instead. I have removed the
"fontStyle": "italic"
from each of the following yet there is no change in the editor.Is there a way to do this that will override a theme's choices? It seems simply not setting it is allowing the theme to rule in the case of
fontStyle
.Steps to Reproduce:
The text was updated successfully, but these errors were encountered: