Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging vscode maximized from one window to another can hide terminal #42999

Closed
Tyriar opened this issue Feb 5, 2018 · 5 comments
Closed

Dragging vscode maximized from one window to another can hide terminal #42999

Tyriar opened this issue Feb 5, 2018 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 5, 2018

I think the expected intersection observer events are not being fired.

Tested on Ubuntu 17.10

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Feb 5, 2018
@Tyriar Tyriar added this to the February 2018 milestone Feb 5, 2018
@Tyriar Tyriar self-assigned this Feb 5, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Feb 5, 2018

Workaround: Hide and show terminal or create a new terminal.

@Kurtz1993
Copy link

Also happening on Windows.

Here's a quick gif.
screen

@Tyriar
Copy link
Member Author

Tyriar commented Feb 15, 2018

@Kurtz1993 I suspected this might also be happening, thanks for verifying 😃

@Tyriar
Copy link
Member Author

Tyriar commented Feb 20, 2018

This doesn't appear to happen in the xterm.js demo with Chrome v64, it might be related to either relayout in VS Code or a bug that's been fixed in Chrome that's still present in Electron.

@Tyriar Tyriar closed this as completed in 8915b73 Feb 20, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Feb 20, 2018

I think it's the latter, that this is fixed in Chromium. I added a workaround to force the terminal renderer to resume when on layout of a visible terminal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants