Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iTerm2 like images displaying on the integrated terminal #44436

Closed
ebraminio opened this issue Feb 26, 2018 · 3 comments
Closed

iTerm2 like images displaying on the integrated terminal #44436

ebraminio opened this issue Feb 26, 2018 · 3 comments
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@ebraminio
Copy link

ebraminio commented Feb 26, 2018 •
edited

iTerm2 has a nice feature http://iterm2.com/documentation-images.html that can display images,

printf "\n\033]1337;File=;inline=1:`cat a.png | base64`\a\n"`

screen shot 2018-02-26 at 11 16 39 pm

I am using the feature for the development of a library which is used on many different platforms including Chrome thus VSCode also, harfbuzz, it would be nice if VSCode could provide the feature also :)
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Feb 26, 2018
@DonJayamanne
Copy link
Contributor

VS Code uses xterm.js to create the terminal.
The same issue was raised in there xtermjs/xterm.js#614

@ebraminio ebraminio mentioned this issue Feb 26, 2018
Closed
@Tyriar Tyriar added the feature-request Request for new features or functionality label Mar 22, 2018
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jun 22, 2018
@mme mme mentioned this issue Jul 23, 2018
Closed
@ebraminio
Copy link
Author

There is a patch for this here xtermjs/xterm.js#1577

@Tyriar
Copy link
Member

Tyriar commented Oct 8, 2019

Let's track this in the xterm.js repo

@Tyriar Tyriar closed this as completed Oct 8, 2019
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ebraminio @DonJayamanne @Tyriar