Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file not found extHost1.log #44717

Closed
atk opened this issue Feb 28, 2018 · 4 comments
Closed

file not found extHost1.log #44717

atk opened this issue Feb 28, 2018 · 4 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug log VS Code log issues verified Verification succeeded
Milestone
February 2018

Comments

@atk
Copy link

atk commented Feb 28, 2018

https://github.com/Microsoft/vscode/blob/93681eb4391b9d365420b3544493fb3a880efd92/src/vs/workbench/api/node/extHostLogService.ts#L29

There seems to be a naming confusion that is only an issue for OSes that differentiate between upper and lower case in the file names; some process [renderer1] throws an error because it does not find extHost1.log, when in the line shown above the logging file is initialized as exthost1.log (small h instead of capital H).
@weinand weinand assigned joaomoreno and unassigned weinand Feb 28, 2018
@joaomoreno joaomoreno assigned sandy081 and unassigned joaomoreno Feb 28, 2018
@sandy081 sandy081 added the log VS Code log issues label Feb 28, 2018
@sandy081 sandy081 added this to the February 2018 milestone Feb 28, 2018
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Feb 28, 2018
@jrieken jrieken reopened this Mar 1, 2018
@jrieken
Copy link
Member

jrieken commented Mar 1, 2018

Still shows as extHost... when invoking Open Log File

screen shot 2018-03-01 at 11 18 44

@jrieken jrieken added the verification-found Issue verification failed label Mar 1, 2018
@sandy081
Copy link
Member

sandy081 commented Mar 1, 2018

Fixed by 1d4ace9

@sandy081 sandy081 closed this as completed Mar 1, 2018
@sandy081 sandy081 removed the verification-found Issue verification failed label Mar 1, 2018
@jrieken jrieken added the verified Verification succeeded label Mar 2, 2018
@mleduque
Copy link

mleduque commented Mar 2, 2018

I still have this problem.

@sandy081
Copy link
Member

sandy081 commented Mar 5, 2018 •
edited

@mleduque Where do you have this problem? In which build?

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug log VS Code log issues verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
6 participants
@joaomoreno @atk @mleduque @jrieken @weinand @sandy081