Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog to uninstall extension with dependencies is a bit weird #45197

Closed
bpasero opened this issue Mar 7, 2018 · 7 comments
Closed

Dialog to uninstall extension with dependencies is a bit weird #45197

bpasero opened this issue Mar 7, 2018 · 7 comments
Assignees
Labels
extensions Issues concerning extensions good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 7, 2018

image

Maybe put "Uninstall" to the button labels?

@sandy081 sandy081 added polish Cleanup and polish issue extensions Issues concerning extensions labels Mar 7, 2018
@sandy081 sandy081 added this to the March 2018 milestone Mar 7, 2018
@camilogiraldo
Copy link
Contributor

camilogiraldo commented Mar 8, 2018

How can I contribute to this ? Any help/guidance around ?

@sandy081 sandy081 added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Mar 12, 2018
@sandy081
Copy link
Member

@camilogiraldo Here is the reference to the code from where this dialog comes from.

@camilogiraldo
Copy link
Contributor

Thanks @sandy081, here's what I purpose for button labels. What do you guys think ?

	const buttons = [
		nls.localize('uninstallOnly', "Extension only"),
		nls.localize('uninstallAll', "Uninstall all"),
		nls.localize('cancel', "Cancel")
	];

Can anyone point me on how can I reproduce the dialog above, I've tried with a couple extensions and just the uninstallConfirmation (without dependencies) pops up

@sandy081
Copy link
Member

@camilogiraldo Try uninstalling extension packs like PHP Extension Pack

@camilogiraldo
Copy link
Contributor

@sandy081 I've tried downloading PHP Extension Pack from marketplace and then installing manually and doesn't seem to work. How can I search for extensions in the development environment for installing them ? Or how that works in the dev env.
Thanks in advance

@sandy081
Copy link
Member

Dev environment does not have market place support and it is available only in main product. Sorry that I cannot let you know to enable the market place support in Dev. But, I can help you with other way.

  • Install all dependencies of PHP Pack first and then install the pack
    image
  • Now uninstall the pack

sandy081 added a commit that referenced this issue Mar 16, 2018
Better uninstall dialog for extensions with dependencies. Fix #45197
sandy081 added a commit that referenced this issue Mar 19, 2018
@Tyriar
Copy link
Member

Tyriar commented Mar 30, 2018

screen shot 2018-03-30 at 10 52 48 am

@Tyriar Tyriar added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants