New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting using ctrl+k,ctrl+c does not work for JSX files #47

Closed
jpierson opened this Issue Nov 18, 2015 · 6 comments

Comments

Projects
None yet
5 participants
@jpierson

jpierson commented Nov 18, 2015

Block commenting using ctrl+k,ctrl+c does not work for JavaScript React JSX files.

@jpierson jpierson changed the title from Block commenting using ctrl+k,ctrl+c does not work for JSX files to Commenting using ctrl+k,ctrl+c does not work for JSX files Nov 18, 2015

@jpierson

This comment has been minimized.

Show comment
Hide comment
@jpierson

jpierson Nov 18, 2015

To clarify, none the commands in the following list work form when working with jsx files with a jsx syntax.
image

Version 0.10.1
Commit df35236
Date 2015-11-17T15:25:33.342Z
Shell 0.34.1
Renderer 45.0.2454.85
Node 4.1.1

jpierson commented Nov 18, 2015

To clarify, none the commands in the following list work form when working with jsx files with a jsx syntax.
image

Version 0.10.1
Commit df35236
Date 2015-11-17T15:25:33.342Z
Shell 0.34.1
Renderer 45.0.2454.85
Node 4.1.1

@tpai

This comment has been minimized.

Show comment
Hide comment
@tpai

tpai Nov 24, 2015

Version <= 0.10.1

Same here.

tpai commented Nov 24, 2015

Version <= 0.10.1

Same here.

@egamma egamma assigned jrieken and unassigned aeschli Nov 24, 2015

@egamma egamma added this to the Nov 2015 - end milestone Nov 24, 2015

@egamma

This comment has been minimized.

Show comment
Hide comment
@egamma

egamma Nov 24, 2015

Member

It was an oversight that we didn't add the a language.configuration.json definition for .jsx files.

Member

egamma commented Nov 24, 2015

It was an oversight that we didn't add the a language.configuration.json definition for .jsx files.

@jrieken jrieken closed this in 3f79721 Nov 24, 2015

egamma added a commit that referenced this issue Nov 24, 2015

Merge pull request #550 from Microsoft/joh/fix47
Fix #47, add support for comments and brackets for JSX

@egamma egamma added the verified label Nov 24, 2015

@jpierson

This comment has been minimized.

Show comment
Hide comment
@jpierson

jpierson Nov 24, 2015

Excellent, good to hear that there is a fix on it's way. Is this something that we could work around by changing a configuration locally until the fix is officially released? I'm looking through the changes now and trying to figure out how that maps to the installed product on Windows.

jpierson commented Nov 24, 2015

Excellent, good to hear that there is a fix on it's way. Is this something that we could work around by changing a configuration locally until the fix is officially released? I'm looking through the changes now and trying to figure out how that maps to the installed product on Windows.

@egamma

This comment has been minimized.

Show comment
Hide comment
@egamma

egamma Nov 24, 2015

Member

These are no code changes and only configuration changes, so you can patch your installation with these changes.

In the installed product the corresponding folder is resources\app\extensions\javascript.

Member

egamma commented Nov 24, 2015

These are no code changes and only configuration changes, so you can patch your installation with these changes.

In the installed product the corresponding folder is resources\app\extensions\javascript.

@tpai

This comment has been minimized.

Show comment
Hide comment
@tpai

tpai Nov 24, 2015

That's great! Thanks @egamma, it has bother me for few days.

tpai commented Nov 24, 2015

That's great! Thanks @egamma, it has bother me for few days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.