Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commenting using ctrl+k,ctrl+c does not work for JSX files #47

Closed
jpierson opened this issue Nov 18, 2015 · 6 comments
Closed

Commenting using ctrl+k,ctrl+c does not work for JSX files #47

jpierson opened this issue Nov 18, 2015 · 6 comments
Assignees
@jrieken
Labels
important Issue identified as high-priority verified Verification succeeded
Milestone
Nov 2015 - end

Comments

@jpierson
Copy link

Block commenting using ctrl+k,ctrl+c does not work for JavaScript React JSX files.
@jpierson jpierson changed the title Block commenting using ctrl+k,ctrl+c does not work for JSX files Commenting using ctrl+k,ctrl+c does not work for JSX files Nov 18, 2015
@jpierson
Copy link
Author

To clarify, none the commands in the following list work form when working with jsx files with a jsx syntax.
image

Version 0.10.1
Commit df35236
Date 2015-11-17T15:25:33.342Z
Shell 0.34.1
Renderer 45.0.2454.85
Node 4.1.1

@tpai
Copy link

tpai commented Nov 24, 2015

Version <= 0.10.1

Same here.

@egamma egamma assigned jrieken and unassigned aeschli Nov 24, 2015
@egamma egamma added this to the Nov 2015 - end milestone Nov 24, 2015
@jrieken jrieken added feature-request Request for new features or functionality important Issue identified as high-priority and removed feature-request Request for new features or functionality labels Nov 24, 2015
@egamma
Copy link
Member

egamma commented Nov 24, 2015

It was an oversight that we didn't add the a language.configuration.json definition for .jsx files.

egamma added a commit that referenced this issue Nov 24, 2015
@egamma
Merge pull request #550 from Microsoft/joh/fix47
b69727d 
Fix #47, add support for comments and brackets for JSX
@egamma egamma added the verified Verification succeeded label Nov 24, 2015
jrieken added a commit that referenced this issue Nov 24, 2015
@jrieken
Fix #47, add support for comments and brackets for JSX
ebbbee2
@jpierson
Copy link
Author

Excellent, good to hear that there is a fix on it's way. Is this something that we could work around by changing a configuration locally until the fix is officially released? I'm looking through the changes now and trying to figure out how that maps to the installed product on Windows.

@egamma
Copy link
Member

egamma commented Nov 24, 2015

These are no code changes and only configuration changes, so you can patch your installation with these changes.

In the installed product the corresponding folder is resources\app\extensions\javascript.

@tpai
Copy link

tpai commented Nov 24, 2015

That's great! Thanks @egamma, it has bother me for few days.

This was referenced Jan 18, 2017
Closed
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
Nov 2015 - end
Development

No branches or pull requests
5 participants
@egamma @tpai @jpierson @jrieken @aeschli