Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse/expand regions does not work #47308

Closed
phamquocduy opened this issue Apr 6, 2018 · 9 comments
Closed

Collapse/expand regions does not work #47308

phamquocduy opened this issue Apr 6, 2018 · 9 comments
Assignees
Labels
editor-folding Editor code folding issues javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@phamquocduy
Copy link

  • VSCode Version: 1.22.1
  • OS Version:

Steps to Reproduce:

  1. Have //#region and //#endregion

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Apr 6, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the editor label Apr 6, 2018
@roblourens
Copy link
Member

In which language? Can you give a full code example?

@PierrickLozach
Copy link

I just noticed the same thing after updating to 1.22.1. I can no longer fold regions.
See a node.js example in the screenshot below:

screen shot 2018-04-07 at 14 24 28

@phamquocduy
Copy link
Author

@PierrickI3 Thank you the the picture

@mpgr04
Copy link

mpgr04 commented Apr 7, 2018

I have the same problem too

@mpgr04
Copy link

mpgr04 commented Apr 7, 2018

For me it happens in JavaScript and PHP

@aeschli aeschli assigned mjbvz and unassigned aeschli Apr 8, 2018
@aeschli
Copy link
Contributor

aeschli commented Apr 8, 2018

Please file a separate issue for PHP, the folding providers are not related (actually nothing has changed for PHP)

@AlCalzone
Copy link

AlCalzone commented Apr 8, 2018

Happens in TypeScript too since 1.22:
unbenannt
Note the difference between regions with description (don't work) and regions without (they work)

Also: Pressing the [-] before //#endregion collapses lines 5-7, which is not useful.

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 9, 2018

Root caused by microsoft/TypeScript#23270

Will be fixed in stable by #47473

@mjbvz mjbvz closed this as completed Apr 9, 2018
@mjbvz mjbvz added typescript Typescript support issues editor-folding Editor code folding issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) javascript JavaScript support issues and removed editor labels Apr 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-folding Editor code folding issues javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

7 participants