Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode mixed writing ,php to html #48238

Closed
lihua06 opened this issue Apr 20, 2018 · 16 comments
Closed

Vscode mixed writing ,php to html #48238

lihua06 opened this issue Apr 20, 2018 · 16 comments
Assignees
Labels
info-needed Issue requires more information from poster php PHP support issues

Comments

@lihua06
Copy link

lihua06 commented Apr 20, 2018

version:1.23.0-insider;
theme:dark+(def dark);
question1: set files.associations, HTML does not add the PHP code hints we want;
question2: when HTML writes PHP, the former < symbol is red;

002

001

@vscodebot
Copy link

vscodebot bot commented Apr 20, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the php PHP support issues label Apr 20, 2018
@roblourens
Copy link
Member

question1: set files.associations, HTML does not add the PHP code hints we want;

What do you mean code hints? Please be specific about what the problem is.

question2: when HTML writes PHP, the former < symbol is red;

It looks like you didn't set files.associations for that screenshot. It will work if you set it.

@roblourens roblourens added the info-needed Issue requires more information from poster label Apr 22, 2018
@lihua06
Copy link
Author

lihua06 commented Apr 22, 2018

question1: PHP intellisense in HTML file
question2:HTML file Write PHP code < symbol is red,so it's thought to be BUG.This problem appears in most theme.Does this effect have a special effect?
01

@lihua06
Copy link
Author

lihua06 commented Apr 22, 2018

@roblourens these are habits problem, if the vscode team can change is the best.thank you

@roblourens
Copy link
Member

roblourens commented Apr 22, 2018

question1: PHP intellisense in HTML file

This works for me. Are you using the builtin PHP intellisense, or an extension?

question 2: This is expected unless you set files.associations in this case, did you?

Both problems could be explained by, you didn't actually set files.associations.

@lihua06
Copy link
Author

lihua06 commented Apr 22, 2018

@roblourens files.associations is set up,Use of builtin PHP intellisense.I hope these can help you

@roblourens
Copy link
Member

Does the status bar say "HTML" or "PHP" on the bottom right side?

@lihua06
Copy link
Author

lihua06 commented Apr 22, 2018

@roblourens display "HTML"

@roblourens
Copy link
Member

Ok, then the files.associations setting is not being applied. Is that in your user settings? Is it being overridden by a setting in workspace settings?

Can you check whether it's applied when you start with --disable-extensions?

@lihua06
Copy link
Author

lihua06 commented Apr 22, 2018

@roblourens disable all extensions,has no effect
yes,user settings;open workspace settings no reaction,interface still displays user settings, and no workspace settings files are visible.
004

@roblourens
Copy link
Member

Can you make sure that the builtin PHP extension is functional by manually changing the language mode to PHP? Click on HTML in the status bar and make sure PHP is in the list that appears, and select PHP.

@lihua06
Copy link
Author

lihua06 commented Apr 23, 2018

manually changing PHP file, PHP intellisense normal work

@roblourens
Copy link
Member

I must be missing something because it seems unlikely that there's a bug in this area.

Could you open developer tools (Help > Toggle Developer Tools) and check for errors in the console?

@lihua06
Copy link
Author

lihua06 commented Apr 24, 2018

@roblourens errors in the console
007

@roblourens
Copy link
Member

Does that show up when you open the php file? What if you set "php.validate.enable": false?

@vscodebot vscodebot bot closed this as completed May 1, 2018
@vscodebot
Copy link

vscodebot bot commented May 1, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster php PHP support issues
Projects
None yet
Development

No branches or pull requests

2 participants