Organize Imports adding semicolons despite semi:false

[ShMcK]

• VSCode Version: 1.23.0
• OS Version: Mac 10.13

"organize imports" automatically adds semi colons to your import statements, even when eslint & prettier set semicolons to false.

 "editor.codeActionsOnSave": {
    "source.organizeImports": true
  },
  "prettier.semi": false,

Steps to Reproduce:

1. Set prettier & eslint semi colons to false
2. Run save on a list of unordered imports
3. See that additional semi colons are added at the end

[rebornix]

AFAIK, the organize imports are provided by TypeScript extension, which doesn't read options from other extensions.

[mzygmunt]

I think it would be good if we could turn off the semicolons in organizImports configuration.

[mjbvz]

Yes, we don't use settings from other extensions.

Enabling/disabling semicolons in generated imports is tracked by microsoft/TypeScript#19882

[jleclanche]

For the record, adding "editor.formatOnSave": true to the config sort of solves that issue. The problem is that the typescript import sorting will not follow prettier rules if you're using prettier, so something like this (from prettier):

import {
    a,
    b,
    c,
    d,
    e,
    f,
    g,
} from "./interfaces";

may get turned into something like this (by typescript):

import { a, b, c, d, e, f, g, ... } from "./interfaces";

And then back into the original. With zero meaningful AST changes, and causing a flash of text on save. Super annoying :(

[jongear]

I can confirm this also happens in javascript files utilizing babel. Adding "editor.formatOnSave": true forces prettier to run and force cleanup the semicolons after organizing

"editor.codeActionsOnSave": {
  "source.organizeImports": true
},
"editor.formatOnSave": true,