Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link that span on multiple lines are not highlighted #51157

Closed
Geobert opened this issue Jun 5, 2018 · 3 comments
Closed

Link that span on multiple lines are not highlighted #51157

Geobert opened this issue Jun 5, 2018 · 3 comments
Assignees
@mjbvz
Labels
grammar Syntax highlighting grammar markdown Markdown support issues *out-of-scope Posted issue is not in scope of VS Code

Comments

@Geobert
Copy link

Geobert commented Jun 5, 2018

  • VSCode Version: Version 1.23.1
    Commit d0182c3
    Date 2018-05-10T17:11:17.614Z
    Shell 1.7.12
    Renderer 58.0.3029.110
    Node 7.9.0
    Architecture x64

  • OS Version: Win7 and Win10

Steps to Reproduce:

  1. write [my link](https://my_url.com)

  2. it's hightlighted
    image

  3. put line break between my and link

  4. hightlighting is gone:
    image

Does this issue occur when all extensions are disabled?: Yes
@Geobert
Copy link
Author

Geobert commented Jun 6, 2018

Same issue with markup.inline.raw.string.markdown

@alexdima
Copy link
Member

alexdima commented Jun 11, 2018 •
edited
Loading

The built-in link detector does not accept line breaks inside links. So, that part is as-designed (i.e. a link across two lines in a plain text file).

I don't know about the specific markdown grammar link detection and if multi-line links are valid in markdown.

@alexdima alexdima assigned mjbvz and unassigned alexdima Jun 11, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 12, 2018

Yes, it is very difficult to write a textmate grammar rule for markdown links that works across lines. I've looked into it but don't think we will get around this anytime soon.

Closing as out of scope

@mjbvz mjbvz closed this as completed Jun 12, 2018
@mjbvz mjbvz added markdown Markdown support issues grammar Syntax highlighting grammar *out-of-scope Posted issue is not in scope of VS Code labels Jun 12, 2018
@Geobert Geobert mentioned this issue Jun 14, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
grammar Syntax highlighting grammar markdown Markdown support issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Geobert @alexdima @mjbvz