Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid: drag and drop no longer possible in some cases when split vertically #52095

Closed
bpasero opened this issue Jun 16, 2018 · 3 comments
Closed

Grid: drag and drop no longer possible in some cases when split vertically #52095

bpasero opened this issue Jun 16, 2018 · 3 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone
June 2018

Comments

@bpasero
Copy link
Member

bpasero commented Jun 16, 2018

before

This was caused by ee1ab9f and seems to go away when .monaco-split-view2 > .split-view-container > .split-view-view gets back overflow: hidden; but I cannot explain why...
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-editor-grid Grid layout issues in the editor area labels Jun 16, 2018
@bpasero bpasero added this to the June 2018 milestone Jun 16, 2018
@bpasero bpasero self-assigned this Jun 16, 2018
@bpasero
Copy link
Member Author

bpasero commented Jun 18, 2018

Does not reproduce anymore.

@bpasero bpasero closed this as completed Jun 18, 2018
@bpasero
Copy link
Member Author

bpasero commented Jun 18, 2018

Still does for dragging a tab.

@bpasero bpasero reopened this Jun 18, 2018
@bpasero
Copy link
Member Author

bpasero commented Jun 19, 2018

This was caused by the container for the overlay exceeding the height of the editor by the size of the title.

@mjbvz mjbvz added the verified Verification succeeded label Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
2 participants
@bpasero @mjbvz