Allow triggering quick fixes from problems view

[mjbvz]

Feature request
Provide a way to trigger a quick fix from the problems view.

For example, for the javascript:

//@ts-check
class Abc {}

new AbC()

A quick fix is available:

But this is not shown or indicated in the problems view:

Additionally, when you click on the problems entry, the editor is not focused so you cannot use a keyboard shortcut to trigger the quick fix

[sandy081]

Following are the quick fixes when shown in problems view.

Let me know if it is ok

@jrieken FYI

[jrieken]

I like it. This is per error/warning, right? Per file we could offer source actions, like orga-imports et al.

[sandy081]

Yeah it is per marker. Sure, we can offer source actions and may be also fix all action on file.

[kieferrm]

@sandy081 do I see if quick fixes are available without opening the context menu?

[sandy081]

@kieferrm No, you don't.
But is not it intuitive to find fixes from context menu in problems view.

Otherwise, we can show overlaid light bulb icon on top of error/warning icon?

[kieferrm]

@sandy081 that's something we should experiment with.

[jrieken]

Otherwise, we can show overlaid light bulb icon on top of error/warning icon?

Maybe on select/hover?

[sandy081]

On select might inline with editor

[sandy081]

I think Source Actions are not a good fit as they are nothing to do with diagnostics.

[sandy081]

A light bulb will be shown if there are quick fixes available for a problem.

For performance reasons, quick fixes check is done by

• Getting the quick fixes for the complete file
• Check if there is a quick fix for the given marker

So, it is necessary that the extension should provide the diagnostics in the quick fixes. See CodeAction.diagnostics

Otherwise, light bulb indicator is not shown, but the quick fixes are shown in the context menu.

I will file an issue against those extension which are not providing diagnostics in quick fixes so that the light bulb can be shown for their diagnostics in Problems view.